This repository was archived by the owner on Nov 30, 2024. It is now read-only.
JRuby specs need to be able to pass args to in_sub_process #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
force-pushed
the
fix_sub_process_on_jruby
branch
2 times, most recently
from
514bebe to
a9a4766
Compare
| @@ -1,7 +1,8 @@ | |||
| module RSpec | |||
| module Support | |||
| module InSubProcess | |||
| if Process.respond_to?(:fork) && !(RUBY_PLATFORM == 'java' && RUBY_VERSION == '1.8.7') | |||
| if Process.respond_to?(:fork) && !(Ruby.jruby? && RUBY_VERSION == '1.8.7') | |||
|
|
|||
|
The stuff I added :+1 to looks good to merge. I think the other things are you trying to get the build passing against the current travis JRuby and we should remove that before merging? If so, I'll be glad to merge this once that's been removed. |
|
Ok, removing a9a4766 and 74e9bf6 per #152 (diff) |
bf4
force-pushed
the
fix_sub_process_on_jruby
branch
from
74e9bf6 to
b4b191e
Compare
|
Cool, I'll merge when appveyor goes green. |
myronmarston
added a commit
that referenced
this pull request
Jan 7, 2015
JRuby specs need to be able to pass args to in_sub_process
|
Merged :). Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #134