Centralized config API extensions into a method.

This lets us re-use that method when we isolate
config in our specs.

Author: myronmarston

lib/rspec/rails.rb

@@ -1,2 +1,11 @@
-require 'rspec/rails/without_filetype_infer'
+require 'rspec/core'
+require 'rspec/collection_matchers'
+require 'rails/version'
+require 'rspec/rails/extensions'
+require 'rspec/rails/view_rendering'
+require 'rspec/rails/adapters'
+require 'rspec/rails/matchers'
+require 'rspec/rails/fixture_support'
+require 'rspec/rails/example'
+require 'rspec/rails/vendor/capybara'
 require 'rspec/rails/configuration'

lib/rspec/rails/configuration.rb

@@ -1,4 +1,111 @@
-RSpec::configure do |c|
+module RSpec
+  module Rails
+    # @private
+    def self.add_rspec_rails_config_api_to(config)
+      # controller settings
+      config.add_setting :infer_base_class_for_anonymous_controllers, :default => true
+
+      # fixture support
+      config.include     RSpec::Rails::FixtureSupport
+      config.add_setting :use_transactional_fixtures, :alias_with => :use_transactional_examples
+      config.add_setting :use_instantiated_fixtures
+      config.add_setting :global_fixtures
+      config.add_setting :fixture_path
+
+      # view rendering settings
+      # This allows us to expose `render_views` as a config option even though it
+      # breaks the convention of other options by using `render_views` as a
+      # command (i.e. render_views = true), where it would normally be used as a
+      # getter. This makes it easier for rspec-rails users because we use
+      # `render_views` directly in example groups, so this aligns the two APIs,
+      # but requires this workaround:
+      config.add_setting :rendering_views, :default => false
+
+      def config.render_views=(val)
+        self.rendering_views = val
+      end
+
+      def config.render_views
+        self.rendering_views = true
+      end
+
+      def config.render_views?
+        rendering_views
+      end
+
+      def config.infer_spec_type_from_file_location!
+        def self.escaped_path(*parts)
+          Regexp.compile(parts.join('[\\\/]') + '[\\\/]')
+        end
+
+        controller_path_regex = self.escaped_path(%w[spec controllers])
+        self.include RSpec::Rails::ControllerExampleGroup,
+          :type          => :controller,
+          :file_path     => lambda { |file_path, metadata|
+            metadata[:type].nil? && controller_path_regex =~ file_path
+          }
+
+        helper_path_regex = self.escaped_path(%w[spec helpers])
+        self.include RSpec::Rails::HelperExampleGroup,
+          :type          => :helper,
+          :file_path     => lambda { |file_path, metadata|
+            metadata[:type].nil? && helper_path_regex =~ file_path
+          }
+
+        mailer_path_regex = self.escaped_path(%w[spec mailers])
+        if defined?(RSpec::Rails::MailerExampleGroup)
+          self.include RSpec::Rails::MailerExampleGroup,
+            :type          => :mailer,
+            :file_path     => lambda { |file_path, metadata|
+              metadata[:type].nil? && mailer_path_regex =~ file_path
+            }
+        end
+
+        model_path_regex = self.escaped_path(%w[spec models])
+        self.include RSpec::Rails::ModelExampleGroup,
+          :type          => :model,
+          :file_path     => lambda { |file_path, metadata|
+            metadata[:type].nil? && model_path_regex =~ file_path
+          }
+
+        request_path_regex = self.escaped_path(%w[spec (requests|integration|api)])
+        self.include RSpec::Rails::RequestExampleGroup,
+          :type          => :request,
+          :file_path     => lambda { |file_path, metadata|
+            metadata[:type].nil? && request_path_regex =~ file_path
+          }
+
+        routing_path_regex = self.escaped_path(%w[spec routing])
+        self.include RSpec::Rails::RoutingExampleGroup,
+          :type          => :routing,
+          :file_path     => lambda { |file_path, metadata|
+            metadata[:type].nil? && routing_path_regex =~ file_path
+          }
+
+        view_path_regex = self.escaped_path(%w[spec views])
+        self.include RSpec::Rails::ViewExampleGroup,
+          :type          => :view,
+          :file_path     => lambda { |file_path, metadata|
+            metadata[:type].nil? && view_path_regex =~ file_path
+          }
+
+        feature_example_regex = self.escaped_path(%w[spec features])
+        self.include RSpec::Rails::FeatureExampleGroup,
+          :type          => :feature,
+          :file_path     => lambda { |file_path, metadata|
+            metadata[:type].nil? && feature_example_regex =~ file_path
+          }
+      end
+    end
+  end
+end
+
+RSpec.configure do |c|
+  RSpec::Rails.add_rspec_rails_config_api_to(c)
+
+  c.backtrace_exclusion_patterns << /vendor\//
+  c.backtrace_exclusion_patterns << /lib\/rspec\/rails/
+
   def c.escaped_path(*parts)
     Regexp.compile(parts.join('[\\\/]') + '[\\\/]')
   end

lib/rspec/rails/example.rb

@@ -7,5 +7,3 @@
 require 'rspec/rails/example/routing_example_group'
 require 'rspec/rails/example/model_example_group'
 require 'rspec/rails/example/feature_example_group'
-
-require 'rspec/rails/infer_type_configuration'

lib/rspec/rails/example/controller_example_group.rb

@@ -1,7 +1,3 @@
-RSpec.configure do |config|
-  config.add_setting :infer_base_class_for_anonymous_controllers, :default => true
-end
-
 module RSpec::Rails
   module ControllerExampleGroup
     extend ActiveSupport::Concern

lib/rspec/rails/fixture_support.rb

@@ -26,14 +26,6 @@ module FixtureSupport
           fixtures RSpec.configuration.global_fixtures if RSpec.configuration.global_fixtures
         end
       end
-
-      RSpec.configure do |c|
-        c.include RSpec::Rails::FixtureSupport
-        c.add_setting :use_transactional_fixtures, :alias_with => :use_transactional_examples
-        c.add_setting :use_instantiated_fixtures
-        c.add_setting :global_fixtures
-        c.add_setting :fixture_path
-      end
     end
   end
 end

lib/rspec/rails/infer_type_configuration.rb

@@ -1,27 +1,5 @@
 require 'action_view/testing/resolvers'
 
-RSpec.configure do |config|
-  # This allows us to expose `render_views` as a config option even though it
-  # breaks the convention of other options by using `render_views` as a
-  # command (i.e. render_views = true), where it would normally be used as a
-  # getter. This makes it easier for rspec-rails users because we use
-  # `render_views` directly in example groups, so this aligns the two APIs,
-  # but requires this workaround:
-  config.add_setting :rendering_views, :default => false
-
-  def config.render_views=(val)
-    self.rendering_views = val
-  end
-
-  def config.render_views
-    self.rendering_views = true
-  end
-
-  def config.render_views?
-    rendering_views
-  end
-end
-
 module RSpec
   module Rails
     module ViewRendering

lib/rspec/rails/view_rendering.rb

@@ -11,13 +11,7 @@ def metadata_with(additional_metadata)
   def with_isolated_config
     original_config = RSpec.configuration
     RSpec.configuration = RSpec::Core::Configuration.new
-    RSpec.configure do |c|
-      c.include RSpec::Rails::FixtureSupport
-      c.add_setting :use_transactional_fixtures, :alias_with => :use_transactional_examples
-      c.add_setting :use_instantiated_fixtures
-      c.add_setting :global_fixtures
-      c.add_setting :fixture_path
-    end
+    RSpec::Rails.add_rspec_rails_config_api_to(RSpec.configuration)
     yield
   ensure
     RSpec.configuration = original_config