Updates for frozen-string-literal compatibility. (#997)

Author: pat

lib/rspec/matchers/built_in/base_matcher.rb

@@ -165,7 +165,7 @@ module DefaultFailureMessages
           # you often only need to override `description`.
           # @return [String]
           def failure_message
-            "expected #{description_of @actual} to #{description}"
+            "expected #{description_of @actual} to #{description}".dup
           end
 
           # @api private
@@ -174,7 +174,7 @@ def failure_message
           # you often only need to override `description`.
           # @return [String]
           def failure_message_when_negated
-            "expected #{description_of @actual} not to #{description}"
+            "expected #{description_of @actual} not to #{description}".dup
           end
 
           # @private

lib/rspec/matchers/built_in/be.rb

@@ -270,7 +270,7 @@ def failure_message_expecting(value)
         def validity_message
           return nil if predicate_accessible?
 
-          msg = "expected #{actual_formatted} to respond to `#{predicate}`"
+          msg = "expected #{actual_formatted} to respond to `#{predicate}`".dup
 
           if private_predicate?
             msg << " but `#{predicate}` is a private method"

lib/rspec/matchers/built_in/respond_to.rb

@@ -131,7 +131,7 @@ def matches_arity?(actual, name)
         end
 
         def with_arity
-          str = ''
+          str = ''.dup
           str << " with #{with_arity_string}" if @expected_arity
           str << " #{str.length == 0 ? 'with' : 'and'} #{with_keywords_string}" if @expected_keywords && @expected_keywords.count > 0
           str << " #{str.length == 0 ? 'with' : 'and'} unlimited arguments" if @unlimited_arguments

lib/rspec/matchers/built_in/yield.rb

@@ -299,7 +299,7 @@ def failure_message_when_negated
         # @private
         def description
           desc = 'yield with args'
-          desc << "(#{expected_arg_description})" unless @expected.empty?
+          desc = "#{desc}(#{expected_arg_description})" unless @expected.empty?
           desc
         end
 

spec/rspec/matchers/built_in/change_spec.rb

@@ -156,7 +156,7 @@ class SomethingExpected
 
   context "with a string" do
     it "passes when actual is modified by the block" do
-      string = "ab"
+      string = "ab".dup
       expect { string << "c" }.to change { string }
     end
 

spec/rspec/matchers/built_in/equal_spec.rb

@@ -14,7 +14,7 @@ def inspect_object(o)
       end
 
       it "does not match when !actual.equal?(expected)" do
-        expect("1").not_to equal("1")
+        expect("1").not_to equal("1".dup)
       end
 
       it "describes itself" do
@@ -33,7 +33,7 @@ def inspect_object(o)
 
       context "when the expected object's #equal? always returns true" do
         let(:strange_string) do
-          string = "foo"
+          string = "foo".dup
 
           def string.equal?(other)
             true
@@ -96,7 +96,7 @@ def string.equal?(other)
       end
 
       it "suggests the `eq` matcher on failure" do
-        expected, actual = "1", "1"
+        expected, actual = "1", "1".dup
         expect {
           expect(actual).to equal(expected)
         }.to fail_with <<-MESSAGE

spec/rspec/matchers/built_in/operators_spec.rb

@@ -15,7 +15,7 @@ def method_missing(name, *args, &block)
 RSpec.describe "operator matchers", :uses_should do
   describe "should ==" do
     it "delegates message to target" do
-      subject = "apple"
+      subject = "apple".dup
       expect(subject).to receive(:==).with("apple").and_return(true)
       subject.should == "apple"
     end
@@ -75,7 +75,7 @@ def method_missing(name, *args, &block)
 
   describe "should_not ==" do
     it "delegates message to target" do
-      subject = "orange"
+      subject = "orange".dup
       expect(subject).to receive(:==).with("apple").and_return(false)
       subject.should_not == "apple"
     end
@@ -94,13 +94,13 @@ def method_missing(name, *args, &block)
 
   describe "should ===" do
     it "delegates message to target" do
-      subject = "apple"
+      subject = "apple".dup
       expect(subject).to receive(:===).with("apple").and_return(true)
       subject.should === "apple"
     end
 
     it "fails when target.===(actual) returns false" do
-      subject = "apple"
+      subject = "apple".dup
       expect(subject).to receive(:===).with("orange").and_return(false)
       expect(RSpec::Expectations).to receive(:fail_with).with(%[expected: "orange"\n     got: "apple" (using ===)], "orange", "apple")
       subject.should === "orange"
@@ -109,13 +109,13 @@ def method_missing(name, *args, &block)
 
   describe "should_not ===" do
     it "delegates message to target" do
-      subject = "orange"
+      subject = "orange".dup
       expect(subject).to receive(:===).with("apple").and_return(false)
       subject.should_not === "apple"
     end
 
     it "fails when target.===(actual) returns false" do
-      subject = "apple"
+      subject = "apple".dup
       expect(subject).to receive(:===).with("apple").and_return(true)
       expect(RSpec::Expectations).to receive(:fail_with).with(%[expected not: === "apple"\n         got:     "apple"], "apple", "apple")
       subject.should_not === "apple"
@@ -124,13 +124,13 @@ def method_missing(name, *args, &block)
 
   describe "should =~" do
     it "delegates message to target" do
-      subject = "foo"
+      subject = "foo".dup
       expect(subject).to receive(:=~).with(/oo/).and_return(true)
       subject.should =~ /oo/
     end
 
     it "fails when target.=~(actual) returns false" do
-      subject = "fu"
+      subject = "fu".dup
       expect(subject).to receive(:=~).with(/oo/).and_return(false)
       expect(RSpec::Expectations).to receive(:fail_with).with(%[expected: /oo/\n     got: "fu" (using =~)], /oo/, "fu")
       subject.should =~ /oo/
@@ -139,13 +139,13 @@ def method_missing(name, *args, &block)
 
   describe "should_not =~" do
     it "delegates message to target" do
-      subject = "fu"
+      subject = "fu".dup
       expect(subject).to receive(:=~).with(/oo/).and_return(false)
       subject.should_not =~ /oo/
     end
 
     it "fails when target.=~(actual) returns false" do
-      subject = "foo"
+      subject = "foo".dup
       expect(subject).to receive(:=~).with(/oo/).and_return(true)
       expect(RSpec::Expectations).to receive(:fail_with).with(%[expected not: =~ /oo/\n         got:    "foo"], /oo/, "foo")
       subject.should_not =~ /oo/

spec/rspec/matchers/built_in/yield_spec.rb

@@ -733,9 +733,10 @@ def each_arg(*args, &block)
     end
 
     it 'fails when the successively yielded args match the matchers (at yield time only)' do
+      values = %w[ food barn ].collect { |value| value.dup }
       expect {
         expect { |b|
-          %w[ food barn ].each do |val|
+          values.each do |val|
             _yield_with_args(val, &b)
             val.sub!(/.+/, '')
           end

spec/rspec/matchers/dsl_spec.rb

@@ -1259,7 +1259,7 @@ def a_method_in_the_example
         end
 
         expected_msg = "RSpec::Matchers::DSL::Matcher"
-        expected_msg << " __raise_no_method_error" unless rbx?
+        expected_msg = "#{expected_msg} __raise_no_method_error" unless rbx?
 
         expect {
           expect(example).to __raise_no_method_error