Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant partial_cmp implementation #1

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Remove redundant partial_cmp implementation #1

merged 2 commits into from
Jan 6, 2024

Conversation

alamb
Copy link

@alamb alamb commented Jan 6, 2024

Proposed patch to apache#8562 to reduce redundant code

@alamb alamb mentioned this pull request Jan 6, 2024
Merged
rspears74
rspears74 approved these changes Jan 6, 2024
View reviewed changes
Copy link
Owner

@rspears74 rspears74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, an if let, this makes sense to me!

@rspears74 rspears74 merged commit 7cf1511 into rspears74:scalarvalue-list-sig Jan 6, 2024
@alamb alamb deleted the alamb/less_copy3 branch January 8, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rspears74 rspears74 rspears74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamb @rspears74