Restricted AvoidLogicInTriggerRule to 1 violation #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
ghost
merged commit 
ghost
mentioned this pull request
|
@up2go-sschwarz we had to revert our merge of you pull request as we were unable to build the engine. There seems to be a problem in the PMD version you based your changes on. It's not buildable. You would have seen this yourself if you would have tested it before doing a PR. @Up2Go-DavidRenz will add a detail section to the wiki on how to test locally before creating an engine PR. |
|
The file "lib/pmd/lib/pmd-apex-5.5.0-apex-jorje-shaded.jar" must not be removed - it contains the apex parser :) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issue #24
rewrote test to ensure the new behaviour works as expected