Skip to content

Commit 1c810a3

Browse files
Changin the ServiceName constant to more closely match the Java implementation. Adding a pragma suppression for method casing - again to more closely match Java.
1 parent 646b7c7 commit 1c810a3

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

RSocketRPCSample/EchoService.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
namespace RSocketRPCSample
1+
#pragma warning disable IDE1006 //Naming rule violation: These words must begin with upper case characters
2+
namespace RSocketRPCSample
23
{
34
using System.Buffers;
45
using System.Threading.Tasks;
@@ -24,12 +25,12 @@ interface IEchoService
2425
[System.Runtime.CompilerServices.CompilerGenerated]
2526
public class EchoService : RSocketService<EchoService>, IEchoService
2627
{
27-
private const string ServiceName = "io.rsocket.rpc.echo" + "." + nameof(EchoService);
28+
private const string SERVICE = "io.rsocket.rpc.echo" + "." + nameof(EchoService);
2829

2930
public EchoService(RSocketClient client) : base(client) { }
3031

3132
//TODO Consider CallerMemberName because the servicename is basically fixed. Also, consider static class...
32-
public Task<BytesValue> requestResponse(BytesValue message, ReadOnlySequence<byte> metadata = default) => __RequestResponse(ServiceName, nameof(requestResponse), message, Google.Protobuf.MessageExtensions.ToByteArray, BytesValue.Parser.ParseFrom, metadata);
33+
public Task<BytesValue> requestResponse(BytesValue message, ReadOnlySequence<byte> metadata = default) => __RequestResponse(SERVICE, nameof(requestResponse), message, Google.Protobuf.MessageExtensions.ToByteArray, BytesValue.Parser.ParseFrom, metadata);
3334

3435

3536

RSocketRPCSample/SimpleService.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ interface ISimpleService
3131
[System.Runtime.CompilerServices.CompilerGenerated]
3232
public class SimpleService : RSocketService<SimpleService>, ISimpleService
3333
{
34-
private const string ServiceName = "io.rsocket.rpc.testing.protobuf" + "." + nameof(SimpleService);
34+
private const string SERVICE = "io.rsocket.rpc.testing.protobuf" + "." + nameof(SimpleService);
3535

3636
public SimpleService(RSocketClient client) : base(client) { }
3737

38-
public Task<SimpleResponse> RequestReply(SimpleRequest message, ReadOnlySequence<byte> metadata = default) => __RequestResponse(ServiceName, nameof(RequestReply), message, Google.Protobuf.MessageExtensions.ToByteArray, SimpleResponse.Parser.ParseFrom, metadata);
38+
public Task<SimpleResponse> RequestReply(SimpleRequest message, ReadOnlySequence<byte> metadata = default) => __RequestResponse(SERVICE, nameof(RequestReply), message, Google.Protobuf.MessageExtensions.ToByteArray, SimpleResponse.Parser.ParseFrom, metadata);
3939

4040

4141
//rpc RequestReply(SimpleRequest) returns(SimpleResponse) { }

0 commit comments

Comments
 (0)