Updates to use CallerMemberName for method signatures in generated code. Fixes to remove warnings.

Author: dbarnett-netifi

RSocket.Core/Transports/SocketTransport.cs

@@ -12,14 +12,15 @@
 
 namespace RSocket.Transports
 {
+	//TODO Readd transport logging - worth it during debugging.
 	public class SocketTransport : IRSocketTransport
 	{
 		private IPEndPoint Endpoint;
 		private Socket Socket;
 
 		internal Task Running { get; private set; } = Task.CompletedTask;
-		private CancellationTokenSource Cancellation;
-		private volatile bool Aborted;
+		//private CancellationTokenSource Cancellation;
+		private volatile bool Aborted;		//TODO Implement cooperative cancellation
 
 		public Uri Url { get; private set; }
 		private LoggerFactory Logger;
@@ -36,9 +37,8 @@ public SocketTransport(Uri url, PipeOptions outputoptions = default, PipeOptions
 			if (url.Port == -1) { throw new ArgumentException("TCP Port must be specified.", nameof(Url)); }
 
 			//Options = options ?? WebSocketsTransport.DefaultWebSocketOptions;
-			//Logger = new Microsoft.Extensions.Logging.LoggerFactory(new[] { new Microsoft.Extensions.Logging.Debug.DebugLoggerProvider() });
+			Logger = new Microsoft.Extensions.Logging.LoggerFactory(new[] { new Microsoft.Extensions.Logging.Debug.DebugLoggerProvider() });
 			(Front, Back) = DuplexPipe.CreatePair(outputoptions, inputoptions);
-			//Transport = new SocketsTransport(Options, Back, WebSocketsTransport.HttpConnectionContext.Default, Logger);
 		}
 
 		public async Task ConnectAsync(CancellationToken cancel = default)
@@ -125,7 +125,7 @@ private async Task ProcessSocketAsync(Socket socket)
 
 		private async Task StartReceiving(Socket socket)
 		{
-			var token = Cancellation?.Token ?? default;
+			var token = default(CancellationToken);	//Cancellation?.Token ?? default;
 
 			try
 			{

RSocket.RPC/RSocketRPCClient.cs

@@ -6,6 +6,7 @@
 
 namespace RSocket.RPC
 {
+	//TODO This has probably dissolved into the Service base class at this point.
 	public class RSocketRPCClient
 	{
 		readonly RSocketClient Client;

RSocketRPCSample/EchoService.cs

@@ -5,7 +5,6 @@ namespace RSocketRPCSample
 	using System.Threading.Tasks;
 	using RSocket;
 	using RSocket.RPC;
-	using Google.Protobuf.WellKnownTypes;
 
 	[System.Runtime.CompilerServices.CompilerGenerated]
 	interface IEchoService
@@ -29,17 +28,7 @@ public class EchoService : RSocketService<EchoService>, IEchoService
 
 		public EchoService(RSocketClient client) : base(client) { }
 
-		//TODO Consider CallerMemberName because the servicename is basically fixed. Also, consider static class...
-		public Task<BytesValue> requestResponse(BytesValue message, ReadOnlySequence<byte> metadata = default) => __RequestResponse(message, Google.Protobuf.MessageExtensions.ToByteArray, BytesValue.Parser.ParseFrom, metadata, service: SERVICE);
-
-
-
-		//async Task ASD()
-		//{
-		//	var thing = new System.Buffers.ReadOnlySequence<byte>(new byte[0]);
-		//	//var result = await requestResponse(thing, thing);
-		//	return 3;
-		//}
+		public Task<Google.Protobuf.WellKnownTypes.BytesValue> requestResponse(Google.Protobuf.WellKnownTypes.BytesValue message, ReadOnlySequence<byte> metadata = default) => __RequestResponse(message, Google.Protobuf.MessageExtensions.ToByteArray, Google.Protobuf.WellKnownTypes.BytesValue.Parser.ParseFrom, metadata, service: SERVICE);
 
 		//public void fireAndForget(ReadOnlySequence<byte> data, ReadOnlySequence<byte> metadata = default) { Client.RequestFireAndForget(null, data, metadata); }