Finalize new transport API and improve stability of QUIC implementation #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 961 files 961 suites 2h 12m 51s ⏱️ Results for commit 74eed32. ♻️ This comment has been updated with latest results. |
whyoleg
force-pushed
the
new-transport-finalize
branch
from
ba67419 to
b06713b
Compare
* use CoroutineScope for both connection and streams * drop isClosedForSend * drop RSocketConnectionHandler, use just connection
…mprove code-organization a bit
…t API and simplify some parts * drop `inheritDispatcher` and use `Unconfined` dispatcher by default * drop possibility to configure channels buffering - use default
…port API and simplify some parts * drop the ability to change dispatcher - always use Default * improve a bit usage of dispatchers and close sequences
… latest change in transport API and simplify some parts
…sport API and improve the correctness of the implementation
…nsport API and SIGNIFICANTLY rework it, improving the correctness of the implementation
Even though they mostly work it's increase tests time a lot and is unstable for mingw
whyoleg
force-pushed
the
new-transport-finalize
branch
from
4d580b6 to
74eed32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some parts of New transport API design were too complicated, so it's required a bit of simplification.
The goal was to improve stability of QUIC implementation on the way and stabilize tests
Modifications: