fix: check for udnefined as well as null in payload.metadata

viglucci · viglucci · commit 639a967ab926 · 2022-01-05T15:22:51.000-06:00
Signed-off-by: Kevin Viglucci &lt;kviglucci@gmail.com&gt;
diff --git a/packages/rsocket-core/src/RSocketMachine.js b/packages/rsocket-core/src/RSocketMachine.js
@@ -888,7 +888,8 @@ class RSocketMachineImpl<D, M> implements RSocketMachine<D, M> {
       flags |= FLAGS.COMPLETE;
       this._subscriptions.delete(streamId);
     }
-    if (payload.metadata !== undefined) {
+    if (payload.metadata !== undefined &&
+        payload.metadata !== null) {
       // eslint-disable-next-line no-bitwise
       flags |= FLAGS.METADATA;
     }

Original file line number	Diff line number	Diff line change
`@@ -888,7 +888,8 @@ class RSocketMachineImpl<D, M> implements RSocketMachine<D, M> {`
`888`	`888`	`flags \|= FLAGS.COMPLETE;`
`889`	`889`	`this._subscriptions.delete(streamId);`
`890`	`890`	`}`
`891`		`- if (payload.metadata !== undefined) {`
	`891`	`+ if (payload.metadata !== undefined &&`
	`892`	`+ payload.metadata !== null) {`
`892`	`893`	`// eslint-disable-next-line no-bitwise`
`893`	`894`	`flags \|= FLAGS.METADATA;`
`894`	`895`	`}`