Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a document page to build on Windows. #887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kimsama
Copy link

@kimsama kimsama commented Jun 9, 2019

Besides adding a document file:

  • modified CMakeLists.txt to resolve to build errors.
  • excluded benchmark stuff to resolve platform issue. (I don't believe 'benchmarks' can be built on Windows because its code uses POSIX socket library)

Motivation and Context

No document about build on Windows. Related issue #886
(Sorry for the direct tackle on master rather than using a branch but there might be no harm because it's just adding a document page and small changes of CMakeList.txt only effect on Windows)

How Has This Been Tested

Tested on Visual Studio 2017 v15.9.11 in Windows10.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- modified CMakeLists.txt to resolve build errors.
- excluded benchmark stuff to resolve platform issue. (I don't believe 'benchmarks' can be built on Windows because it's code uses POXIS socket library)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant