Skip to content

Commit e7dd075

Browse files
simpkinsfacebook-github-bot
authored andcommitted
fbcode_builder: rename add_thrift_cpp2_library() to add_fbthrift_cpp_library()
Summary: Rename the `ThriftCppLibrary.cmake` file to `FBThriftCppLibrary.cmake`, and also rename `add_thrift_cpp2_library()` to `add_fbthrift_cpp_library()`. Explicitly calling this `fbthrift` helps clearly distinguish that this is intended for use with fbthrift (https://github.com/facebook/fbthrift/), as opposed to Apache thrift. Reviewed By: wez Differential Revision: D16738440 fbshipit-source-id: 9b255e06b71c98ad74a34989f564a211958dcdd5
1 parent a74ad56 commit e7dd075

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

build/fbcode_builder/CMake/ThriftCppLibrary.cmake renamed to build/fbcode_builder/CMake/FBThriftCppLibrary.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ include(FBCMakeParseArgs)
2020
# Defaults to "${INCLUDE_DIR}/thrift-files" if not specified.
2121
# The caller must still call install() to install the thrift library if
2222
# desired.
23-
function(add_thrift_cpp2_library LIB_NAME THRIFT_FILE)
23+
function(add_fbthrift_cpp_library LIB_NAME THRIFT_FILE)
2424
# Parse the arguments
2525
set(one_value_args INCLUDE_DIR)
2626
set(multi_value_args SERVICES DEPENDS OPTIONS THRIFT_INCLUDE_DIR)
@@ -93,7 +93,7 @@ function(add_thrift_cpp2_library LIB_NAME THRIFT_FILE)
9393
# include list as a single argument and split it up before invoking the
9494
# thrift compiler.
9595
if (NOT POLICY CMP0067)
96-
message(FATAL_ERROR "add_thrift_cpp2_library() requires CMake 3.8+")
96+
message(FATAL_ERROR "add_fbthrift_cpp_library() requires CMake 3.8+")
9797
endif()
9898
set(
9999
thrift_include_options

0 commit comments

Comments
 (0)