Skip to content

New option to plsql-spec command to indicate when to capture the output #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2013

Conversation

d1egoaz
Copy link
Contributor

@d1egoaz d1egoaz commented Apr 22, 2013

The idea with this commit, is to provide a way to show the output when Thor runs the rspec command,

In this commit @rsim added the option to Capture the log, and there is no way to disable the option :(
8c76f47

The problem with :capture => true is that hide errors that are outside rspec, I ask about this option in the Google Group:
https://groups.google.com/forum/?fromgroups=#!topic/oracle-enhanced/SmkETvkc2i8

I added a new option "--capture" to "plsql-spec" in order to indicate when do you don't want to capture the errors:

    plsql-spec run  --capture=false

If you don't provide the capture option, the default value is true (How it works today)

    plsql-spec run

In this example I have an error in the test_spec.rb file, I'm requiring a non existing gem

require "spec_helper.rb"
require "non_existing_gem"

Before my commit, this is the output
rake probar[ejemplo] executes internally the "plsql-spec" run command

It's very difficult to catch the error
notes marker

After the commit, with plsql-spec run --capture=false this is the output
notes marker

rsim added a commit that referenced this pull request Apr 23, 2013
New option to plsql-spec command to indicate when to capture the output
@rsim rsim merged commit 7b0027d into rsim:master Apr 23, 2013
@javornikolov javornikolov mentioned this pull request Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants