Merge pull request #132 from rsheldiii/v1/g20-spacebar-fix

rsheldiii · web-flow · commit edfc02e27b51 · 2022-02-19T20:31:43.000-05:00
V1: Fix g20 spacebar having closed bottom
diff --git a/customizer.scad b/customizer.scad
@@ -788,8 +788,8 @@ function add_rounding(p, radius)=[for(i=[0:len(p)-1])[p[i].x,p[i].y, radius]];
 function unit_length(length) = unit * (length - 1) + 18.16;
 
 module spacebar() {
-  $inverted_dish = true;
-  $dish_type = "sideways cylindrical";
+  $inverted_dish = $dish_type != "disable";
+  $dish_type = $dish_type != "disable" ? "sideways cylindrical" : "disable";
   6_25u() stabilized(mm=50) children();
 }
 
diff --git a/src/key_types.scad b/src/key_types.scad
@@ -1,8 +1,8 @@
 include <functions.scad>
 
 module spacebar() {
-  $inverted_dish = true;
-  $dish_type = "sideways cylindrical";
+  $inverted_dish = $dish_type != "disable";
+  $dish_type = $dish_type != "disable" ? "sideways cylindrical" : "disable";
   6_25u() stabilized(mm=50) children();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -788,8 +788,8 @@ function add_rounding(p, radius)=[for(i=[0:len(p)-1])[p[i].x,p[i].y, radius]];`
`788`	`788`	`function unit_length(length) = unit * (length - 1) + 18.16;`
`789`	`789`
`790`	`790`	`module spacebar() {`
`791`		`- $inverted_dish = true;`
`792`		`- $dish_type = "sideways cylindrical";`
	`791`	`+ $inverted_dish = $dish_type != "disable";`
	`792`	`+ $dish_type = $dish_type != "disable" ? "sideways cylindrical" : "disable";`
`793`	`793`	`6_25u() stabilized(mm=50) children();`
`794`	`794`	`}`
`795`	`795`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	`include <functions.scad>`
`2`	`2`
`3`	`3`	`module spacebar() {`
`4`		`- $inverted_dish = true;`
`5`		`- $dish_type = "sideways cylindrical";`
	`4`	`+ $inverted_dish = $dish_type != "disable";`
	`5`	`+ $dish_type = $dish_type != "disable" ? "sideways cylindrical" : "disable";`
`6`	`6`	`6_25u() stabilized(mm=50) children();`
`7`	`7`	`}`
`8`	`8`