Shrink redundant code, add implicit TX beamforming parser #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @anphsw, MT7610 and MT7612 are quite different chips. MT7610 is a single chain chip, while MT7612 is a MIMO with 2 streams. Correspondingly, they have different per-modulation table formats and, as far as I remember, different offsets of the tx power configurations. Layouts are similar up to some extent, but not literally the same. So, I can not merge this series, sorry. The similar case regarding MT7610/MT7612U already was discussed in #1. You can also find some information regarding layout details in this opensource driver project: https://github.com/openwrt/mt76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.