This repository was archived by the owner on Oct 23, 2022. It is now read-only.
Make IpldDag and Ipns async_traits #285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ljedrz <ljedrz@gmail.com>
|
Oof, forgot the tests 😄. |
Signed-off-by: ljedrz <ljedrz@gmail.com>
ljedrz
force-pushed
the
async_trait_dag_ipns
branch
from
ed13282 to
aca0b14
Compare
koivunej
reviewed
Aug 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a part of #264 which was surprisingly painless and seems more idiomatic than the current approach of creating ad-hoc intermediate
structs containing anIpfs(which is internally anArc).