Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing #24

Open
mbhall88 opened this issue Feb 6, 2019 · 0 comments
Open

Tests failing #24

mbhall88 opened this issue Feb 6, 2019 · 0 comments

Comments

@mbhall88
Copy link

mbhall88 commented Feb 6, 2019

Hey @rrwick ,

I just tried running the tests and some of them failed.

The version of python I was running on is 3.5.2

I ran tests with python3 -m unittest from the project root directory.

In total 7 tests failed. All with the same message - an example is below:

======================================================================
ERROR: test_find_all_fast5s_verbose (tests.test_load_fast5s.TestLoadFast5s)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/Deepbinner/tests/test_load_fast5s.py", line 37, in test_find_all_fast5s_verbose
    fast5s = deepbinner.load_fast5s.find_all_fast5s(self.fast5_dir, verbose=True)
  File "/root/Deepbinner/deepbinner/load_fast5s.py", line 57, in find_all_fast5s
    for dir_name, _, filenames in os.walk(directory):
  File "/usr/lib/python3.5/os.py", line 371, in walk
    scandir_it = scandir(top)
TypeError: scandir: illegal type for path parameter

Seems maybe os.scandir doesn't take a pathlib.Path object in python 3.5 maybe?

@mbhall88 mbhall88 changed the title Test failing Tests failing Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant