chore: abstract types to shared package #1593

daibhin · 2024-11-01T11:56:26Z

Abstracted all the shared types from the rrweb-snapshot project into the shared @rrweb/types package as was done in #1475

Additional context in https://rrweb.slack.com/archives/C0614SW58TW/p1730134366873209

changeset-bot · 2024-11-01T11:56:29Z

🦋 Changeset detected

Latest commit: 8508bed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages

Name	Type
@rrweb/all	Major
rrdom-nodejs	Major
rrdom	Major
rrweb-snapshot	Major
rrweb	Major
@rrweb/rrweb-plugin-canvas-webrtc-record	Major
rrweb-player	Major
@rrweb/replay	Major
@rrweb/record	Major
@rrweb/types	Major
@rrweb/packer	Major
@rrweb/utils	Major
@rrweb/web-extension	Major
rrvideo	Major
@rrweb/rrweb-plugin-console-record	Major
@rrweb/rrweb-plugin-console-replay	Major
@rrweb/rrweb-plugin-sequential-id-record	Major
@rrweb/rrweb-plugin-sequential-id-replay	Major
@rrweb/rrweb-plugin-canvas-webrtc-replay	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/rrdom-nodejs/src/document-nodejs.ts

eoghanmurray · 2024-11-29T16:03:43Z

Thanks for doing this thankless work!
I was able to rebase #1475 on top of this, so all good as far as I'm concerned.
@daibhin could you add a changeset as I'm unable to commit directly to this branch?

daibhin · 2024-11-30T17:29:09Z

@eoghanmurray just went to do it there but looks like you got there ahead of me :)

eoghanmurray · 2024-12-02T11:58:47Z

Not sure why the bot isn't picking up that there's a changeset; it seemed to have failed when I added it with the changeset-bot

Juice10

Thanks for doing all this work @daibhin! This will make landing the asset PRs that @eoghanmurray and I have been working on a lot less painful

.changeset/soft-worms-tan.md

packages/types/src/index.ts

… dn-chore/type-changes

.changeset/soft-worms-tan.md

* chore: update types * small typing change * fix typing issue * typed node * add extra lint skip * add changeset --------- Co-authored-by: Eoghan Murray <eoghan@getthere.ie> Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>

* Single style capture (rrweb-io#1437) Support a contrived/rare case where a <style> element has multiple text node children (this is usually only possible to recreate via javascript append) ... this PR fixes cases where there are subsequent text mutations to these nodes; previously these would have been lost * In this scenario, a new CSS comment may now be inserted into the captured `_cssText` for a <style> element to show where it should be broken up into text elements upon replay: `/* rr_split */` * The new 'can record and replay style mutations' test is the principal way to the problematic scenarios, and is a detailed 'catch-all' test with many checks to cover most of the ways things can fail * There are new tests for splitting/rebuilding the css using the rr_split marker * The prior 'dynamic stylesheet' route is now the main route for serializing a stylesheet; dynamic stylesheet were missed out in rrweb-io#1533 but that case is now covered with this PR This PR was originally extracted from rrweb-io#1475 so the initial motivation was to change the approach on stringifying <style> elements to do so in a single place. This is also the motivating factor for always serializing <style> elements via the `_cssText` attribute rather than in it's childNodes; in rrweb-io#1475 we will be delaying populating `_cssText` for performance and instead recorrding them as assets. Thanks for the detailed review to Justin Halsall <Juice10@users.noreply.github.com> & Yun Feng <https://github.com/YunFeng0817> * Simplify the hover replacement function (rrweb-io#1535) Simplify the hover replacement function, which has been borrowed from postcss-pseudo-classes Note: 'parses nested commas in selectors correctly' was failing after this PR, however I don't think that the previous behaviour was desirable, so have added a new test to formalize this expectation * fix some typos in optimize-storage.md (rrweb-io#1565) * fix some typos in optimize-storage.md * Update docs/recipes/optimize-storage.md * Create metal-mugs-mate.md --------- Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com> * fix(rrdom): Ignore invalid DOM attributes when diffing (rrweb-io#1561) * fix(rrdom): Ignore invalid DOM attributes when diffing (rrweb-io#213) We encountered an issue where replays with invalid attributes (e.g. `@click`) would break rendering the replay after seeking. The exception bubbles up to [here](https://github.com/rrweb-io/rrweb/blob/62093d4385a09eb0980c2ac02d97eea5ce2882be/packages/rrweb/src/replay/index.ts#L270-L279), which means the replay will continue to play, but the replay mirror will be incomplete. Closes https://github.com/getsentry/team-replay/issues/458 * add changeset * fix(snapshot): dimensions for blocked element not being applied (rrweb-io#1331) fix for replay of a blocked element when using 'fast forward' (rrdom) - Dimensions were not being properly applied when you seek to a position in the replay. Need to use `setProperty` rather than trying to set the width/height directly * ref: isParentRemoved to cache subtree (rrweb-io#1543) * ref: isParentRemoved to cache subtree * ref: cache at insertion too * ref: remove wrapper function --------- Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com> * fix: angular wrapped mutationobserver detection (rrweb-io#1597) * fix: angular wrapped mutationobserver detection * add change set * fix * prettier * following posthog prod * manually prettier * Update .changeset/moody-experts-build.md Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com> --------- Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com> * chore: abstract types to shared package (rrweb-io#1593) * chore: update types * small typing change * fix typing issue * typed node * add extra lint skip * add changeset --------- Co-authored-by: Eoghan Murray <eoghan@getthere.ie> Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com> * Apply formatting changes * fix: wrong imports for Amplitude * chore: fix changeset names --------- Co-authored-by: Eoghan Murray <eoghan@getthere.ie> Co-authored-by: Riadh Mouamnia <85134557+riadhmouamnia@users.noreply.github.com> Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com> Co-authored-by: Billy Vong <billyvg@users.noreply.github.com> Co-authored-by: Jonas <jonas@badalic.com> Co-authored-by: Paul D'Ambra <paul.dambra@gmail.com> Co-authored-by: David Newell <david@posthog.com> Co-authored-by: jxiwang <jxiwang@users.noreply.github.com>

daibhin added 2 commits November 1, 2024 10:29

chore: update types

5869c93

small typing change

1addf77

daibhin added 2 commits November 1, 2024 12:13

fix typing issue

a6a8f23

typed node

040e941

daibhin mentioned this pull request Nov 4, 2024

chore: upgrade rrweb to alpha.17 PostHog/posthog-js#1489

Merged

3 tasks

Juice10 self-requested a review November 8, 2024 08:30

Juice10 self-assigned this Nov 8, 2024

pauldambra mentioned this pull request Nov 20, 2024

Cannot find module 'rrweb-snapshot' or its corresponding type declarations PostHog/posthog-js#252

Open

add extra lint skip

ac3652d

daibhin commented Nov 20, 2024

View reviewed changes

packages/rrdom-nodejs/src/document-nodejs.ts Show resolved Hide resolved

Create soft-worms-tan.md

66632c4

add changeset

9772049

Juice10 requested changes Dec 6, 2024

View reviewed changes

.changeset/soft-worms-tan.md Outdated Show resolved Hide resolved

packages/types/src/index.ts Show resolved Hide resolved

packages/types/src/index.ts Show resolved Hide resolved

daibhin added 2 commits December 6, 2024 09:07

Merge branch 'dn-chore/type-changes' of github.com:daibhin/rrweb into…

8ca737e

… dn-chore/type-changes

update changeset

6e62b4c

daibhin requested a review from Juice10 December 6, 2024 10:12

Juice10 reviewed Dec 6, 2024

View reviewed changes

.changeset/soft-worms-tan.md Outdated Show resolved Hide resolved

Update soft-worms-tan.md

cbdb5e8

Juice10 reviewed Dec 6, 2024

View reviewed changes

.changeset/soft-worms-tan.md Outdated Show resolved Hide resolved

Update soft-worms-tan.md

8508bed

Juice10 approved these changes Dec 6, 2024

View reviewed changes

Juice10 merged commit 5a78938 into rrweb-io:master Dec 6, 2024
6 checks passed

github-actions bot mentioned this pull request Dec 6, 2024

Version Packages (alpha) #1554

Merged

daibhin deleted the dn-chore/type-changes branch December 6, 2024 14:06

This was referenced Feb 20, 2025

assets + stylesheet assets #1475

Open

Add Asset event type and capture assets #1239

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: abstract types to shared package #1593

chore: abstract types to shared package #1593

Uh oh!

daibhin commented Nov 1, 2024

Uh oh!

changeset-bot bot commented Nov 1, 2024 •

edited

Loading

Uh oh!

Uh oh!

eoghanmurray commented Nov 29, 2024

Uh oh!

daibhin commented Nov 30, 2024

Uh oh!

eoghanmurray commented Dec 2, 2024

Uh oh!

Juice10 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chore: abstract types to shared package #1593

chore: abstract types to shared package #1593

Uh oh!

Conversation

daibhin commented Nov 1, 2024

Uh oh!

changeset-bot bot commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

eoghanmurray commented Nov 29, 2024

Uh oh!

daibhin commented Nov 30, 2024

Uh oh!

eoghanmurray commented Dec 2, 2024

Uh oh!

Juice10 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

changeset-bot bot commented Nov 1, 2024 •

edited

Loading