From ba4b72031d202388768779e4f908b9cc7b0271d0 Mon Sep 17 00:00:00 2001 From: Felix Mosheev <9304194+felixmosh@users.noreply.github.com> Date: Mon, 4 Sep 2023 18:15:33 +0300 Subject: [PATCH] fix: add error prop to FormGroup (#4437) --- src/collections/Form/FormGroup.d.ts | 3 +++ src/collections/Form/FormGroup.js | 6 +++++- test/specs/collections/Form/FormGroup-test.js | 1 + 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/collections/Form/FormGroup.d.ts b/src/collections/Form/FormGroup.d.ts index 8c1c8bc54f..697a863197 100644 --- a/src/collections/Form/FormGroup.d.ts +++ b/src/collections/Form/FormGroup.d.ts @@ -18,6 +18,9 @@ export interface StrictFormGroupProps { /** A Form Group can be disabled. */ disabled?: boolean + /** A Form Group can have error. */ + error?: boolean + /** Fields can show related choices. */ grouped?: boolean diff --git a/src/collections/Form/FormGroup.js b/src/collections/Form/FormGroup.js index 0226d1ed83..cbfb2bcc89 100644 --- a/src/collections/Form/FormGroup.js +++ b/src/collections/Form/FormGroup.js @@ -16,9 +16,10 @@ import { * @see Form */ const FormGroup = React.forwardRef((props, ref) => { - const { children, className, disabled, grouped, inline, unstackable, widths } = props + const { children, className, disabled, error, grouped, inline, unstackable, widths } = props const classes = cx( + useKeyOnly(error, 'error'), useKeyOnly(disabled, 'disabled'), useKeyOnly(grouped, 'grouped'), useKeyOnly(inline, 'inline'), @@ -52,6 +53,9 @@ FormGroup.propTypes = { /** A Form Group can be disabled. */ disabled: PropTypes.bool, + /** A Form Group can have error. */ + error: PropTypes.bool, + /** Fields can show related choices. */ grouped: customPropTypes.every([customPropTypes.disallow(['inline']), PropTypes.bool]), diff --git a/test/specs/collections/Form/FormGroup-test.js b/test/specs/collections/Form/FormGroup-test.js index bb51036dfd..ad3e8b390f 100644 --- a/test/specs/collections/Form/FormGroup-test.js +++ b/test/specs/collections/Form/FormGroup-test.js @@ -16,6 +16,7 @@ describe('FormGroup', () => { common.propKeyOnlyToClassName(FormGroup, 'grouped') common.propKeyOnlyToClassName(FormGroup, 'disabled') common.propKeyOnlyToClassName(FormGroup, 'inline') + common.propKeyOnlyToClassName(FormGroup, 'error') common.propKeyOnlyToClassName(FormGroup, 'unstackable') common.forwardsRef(FormGroup)