forked from hotosm/tasking-manager
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathvalidator_service.py
440 lines (389 loc) · 16.7 KB
/
validator_service.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
from flask import current_app
from sqlalchemy import text
from backend.exceptions import NotFound
from backend.models.dtos.mapping_dto import TaskDTOs
from backend.models.dtos.stats_dto import Pagination
from backend.models.dtos.validator_dto import (
LockForValidationDTO,
UnlockAfterValidationDTO,
MappedTasks,
StopValidationDTO,
InvalidatedTask,
InvalidatedTasks,
RevertUserTasksDTO,
)
from backend.models.postgis.statuses import ValidatingNotAllowed
from backend.models.postgis.task import (
Task,
TaskStatus,
TaskHistory,
TaskInvalidationHistory,
TaskMappingIssue,
)
from backend.models.postgis.utils import UserLicenseError, timestamp
from backend.models.postgis.project_info import ProjectInfo
from backend.services.messaging.message_service import MessageService
from backend.services.project_service import ProjectService, ProjectAdminService
from backend.services.stats_service import StatsService
from backend.services.users.user_service import UserService
from backend.services.mapping_service import MappingService
class ValidatorServiceError(Exception):
"""Custom exception to notify callers that error has occurred"""
def __init__(self, message):
if current_app:
current_app.logger.debug(message)
class ValidatorService:
@staticmethod
def lock_tasks_for_validation(validation_dto: LockForValidationDTO) -> TaskDTOs:
"""
Lock supplied tasks for validation
:raises ValidatorServiceError
"""
# Loop supplied tasks to check they can all be locked for validation
tasks_to_lock = []
for task_id in validation_dto.task_ids:
task = Task.get(task_id, validation_dto.project_id)
if task is None:
raise NotFound(
sub_code="TASK_NOT_FOUND",
task_id=task_id,
project_id=validation_dto.project_id,
)
if not (
task.locked_by == validation_dto.user_id
and TaskStatus(task.task_status) == TaskStatus.LOCKED_FOR_VALIDATION
):
if TaskStatus(task.task_status) not in [
TaskStatus.MAPPED,
TaskStatus.INVALIDATED,
TaskStatus.BADIMAGERY,
]:
raise ValidatorServiceError(
f"NotReadyForValidation- Task {task_id} is not MAPPED, BADIMAGERY or INVALIDATED"
)
user_can_validate = ValidatorService._user_can_validate_task(
validation_dto.user_id, task.mapped_by
)
if not user_can_validate:
raise ValidatorServiceError(
"CannotValidateMappedTask-"
+ "Tasks cannot be validated by the same user who marked task as mapped or badimagery"
)
tasks_to_lock.append(task)
user_can_validate, error_reason = ProjectService.is_user_permitted_to_validate(
validation_dto.project_id, validation_dto.user_id
)
if not user_can_validate:
if error_reason == ValidatingNotAllowed.USER_NOT_ACCEPTED_LICENSE:
raise UserLicenseError("User must accept license to map this task")
elif error_reason == ValidatingNotAllowed.USER_NOT_ON_ALLOWED_LIST:
raise ValidatorServiceError(
"UserNotAllowed- Validation not allowed because: User not on allowed list"
)
elif error_reason == ValidatingNotAllowed.PROJECT_NOT_PUBLISHED:
raise ValidatorServiceError(
"ProjectNotPublished- Validation not allowed because: Project not published"
)
elif error_reason == ValidatingNotAllowed.USER_ALREADY_HAS_TASK_LOCKED:
user_tasks = Task.get_locked_tasks_for_user(validation_dto.user_id)
if set(user_tasks.locked_tasks) != set(validation_dto.task_ids):
raise ValidatorServiceError(
"UserAlreadyHasTaskLocked- User already has a task locked"
)
else:
raise ValidatorServiceError(
f"ValidtionNotAllowed- Validation not allowed because: {error_reason}"
)
# Lock all tasks for validation
dtos = []
for task in tasks_to_lock:
task.lock_task_for_validating(validation_dto.user_id)
dtos.append(task.as_dto_with_instructions(validation_dto.preferred_locale))
task_dtos = TaskDTOs()
task_dtos.tasks = dtos
return task_dtos
@staticmethod
def _user_can_validate_task(user_id: int, mapped_by: int) -> bool:
"""
check whether a user is able to validate a task. Users cannot validate their own tasks unless they are a PM
(admin counts as project manager too)
:param user_id: id of user attempting to validate
:param mapped_by: id of user who mapped the task
:return: Boolean
"""
is_admin = UserService.is_user_an_admin(user_id)
if is_admin:
return True
else:
mapped_by_me = mapped_by == user_id
if not mapped_by_me:
return True
return False
@staticmethod
def unlock_tasks_after_validation(
validated_dto: UnlockAfterValidationDTO,
) -> TaskDTOs:
"""
Unlocks supplied tasks after validation
:raises ValidatorServiceError
"""
validated_tasks = validated_dto.validated_tasks
project_id = validated_dto.project_id
user_id = validated_dto.user_id
tasks_to_unlock = ValidatorService.get_tasks_locked_by_user(
project_id, validated_tasks, user_id
)
# Unlock all tasks
dtos = []
message_sent_to = []
for task_to_unlock in tasks_to_unlock:
task = task_to_unlock["task"]
if task_to_unlock["comment"]:
# Parses comment to see if any users have been @'d
MessageService.send_message_after_comment(
validated_dto.user_id,
task_to_unlock["comment"],
task.id,
validated_dto.project_id,
)
if (
task_to_unlock["new_state"] == TaskStatus.VALIDATED
or task_to_unlock["new_state"] == TaskStatus.INVALIDATED
):
# All mappers get a notification if their task has been validated or invalidated.
# Only once if multiple tasks mapped
if task.mapped_by not in message_sent_to:
MessageService.send_message_after_validation(
task_to_unlock["new_state"],
validated_dto.user_id,
task.mapped_by,
task.id,
validated_dto.project_id,
)
message_sent_to.append(task.mapped_by)
if task_to_unlock["new_state"] == TaskStatus.VALIDATED:
# Set last_validation_date for the mapper to current date
task.mapper.last_validation_date = timestamp()
# Update stats if user setting task to a different state from previous state
prev_status = TaskHistory.get_last_status(project_id, task.id)
if prev_status != task_to_unlock["new_state"]:
StatsService.update_stats_after_task_state_change(
validated_dto.project_id,
validated_dto.user_id,
prev_status,
task_to_unlock["new_state"],
)
task_mapping_issues = ValidatorService.get_task_mapping_issues(
task_to_unlock
)
task.unlock_task(
validated_dto.user_id,
task_to_unlock["new_state"],
task_to_unlock["comment"],
issues=task_mapping_issues,
)
dtos.append(task.as_dto_with_instructions(validated_dto.preferred_locale))
ProjectService.send_email_on_project_progress(validated_dto.project_id)
task_dtos = TaskDTOs()
task_dtos.tasks = dtos
return task_dtos
@staticmethod
def stop_validating_tasks(stop_validating_dto: StopValidationDTO) -> TaskDTOs:
"""
Unlocks supplied tasks after validation
:raises ValidatorServiceError
"""
reset_tasks = stop_validating_dto.reset_tasks
project_id = stop_validating_dto.project_id
user_id = stop_validating_dto.user_id
tasks_to_unlock = ValidatorService.get_tasks_locked_by_user(
project_id, reset_tasks, user_id
)
dtos = []
for task_to_unlock in tasks_to_unlock:
task = task_to_unlock["task"]
if task_to_unlock["comment"]:
# Parses comment to see if any users have been @'d
MessageService.send_message_after_comment(
user_id, task_to_unlock["comment"], task.id, project_id
)
task.reset_lock(user_id, task_to_unlock["comment"])
dtos.append(
task.as_dto_with_instructions(stop_validating_dto.preferred_locale)
)
task_dtos = TaskDTOs()
task_dtos.tasks = dtos
return task_dtos
@staticmethod
def get_tasks_locked_by_user(project_id: int, unlock_tasks, user_id: int):
"""
Returns tasks specified by project id and unlock_tasks list if found and locked for validation by user,
otherwise raises ValidatorServiceError, NotFound
:param project_id:
:param unlock_tasks: List of tasks to be unlocked
:param user_id:
:return: List of Tasks
:raises ValidatorServiceError
:raises NotFound
"""
tasks_to_unlock = []
# Loop supplied tasks to check they can all be unlocked
for unlock_task in unlock_tasks:
task = Task.get(unlock_task.task_id, project_id)
if task is None:
raise NotFound(
sub_code="TASK_NOT_FOUND",
task_id=unlock_task.task_id,
project_id=project_id,
)
current_state = TaskStatus(task.task_status)
if current_state != TaskStatus.LOCKED_FOR_VALIDATION:
raise ValidatorServiceError(
f"NotLockedForValidation- Task {unlock_task.task_id} is not LOCKED_FOR_VALIDATION"
)
if task.locked_by != user_id:
raise ValidatorServiceError(
"TaskNotOwned- Attempting to unlock a task owned by another user"
)
if hasattr(unlock_task, "status"):
# we know what status we ate going to be setting to on unlock
new_status = TaskStatus[unlock_task.status]
else:
new_status = None
tasks_to_unlock.append(
dict(
task=task,
new_state=new_status,
comment=unlock_task.comment,
issues=unlock_task.issues,
)
)
return tasks_to_unlock
@staticmethod
def get_mapped_tasks_by_user(project_id: int) -> MappedTasks:
"""Get all mapped tasks on the project grouped by user"""
mapped_tasks = Task.get_mapped_tasks_by_user(project_id)
return mapped_tasks
@staticmethod
def get_user_invalidated_tasks(
as_validator,
username: str,
preferred_locale: str,
closed=None,
project_id=None,
page=1,
page_size=10,
sort_by="updated_date",
sort_direction="desc",
) -> InvalidatedTasks:
"""Get invalidated tasks either mapped or invalidated by the user"""
user = UserService.get_user_by_username(username)
query = (
TaskInvalidationHistory.query.filter_by(invalidator_id=user.id)
if as_validator
else TaskInvalidationHistory.query.filter_by(mapper_id=user.id)
)
if closed is not None:
query = query.filter_by(is_closed=closed)
if project_id is not None:
query = query.filter_by(project_id=project_id)
results = query.order_by(text(sort_by + " " + sort_direction)).paginate(
page=page, per_page=page_size, error_out=True
)
project_names = {}
invalidated_tasks_dto = InvalidatedTasks()
for entry in results.items:
dto = InvalidatedTask()
dto.task_id = entry.task_id
dto.project_id = entry.project_id
dto.history_id = entry.invalidation_history_id
dto.closed = entry.is_closed
dto.updated_date = entry.updated_date
if dto.project_id not in project_names:
project_names[dto.project_id] = ProjectInfo.get_dto_for_locale(
dto.project_id, preferred_locale
).name
dto.project_name = project_names[dto.project_id]
invalidated_tasks_dto.invalidated_tasks.append(dto)
invalidated_tasks_dto.pagination = Pagination(results)
return invalidated_tasks_dto
@staticmethod
def invalidate_all_tasks(project_id: int, user_id: int):
"""Invalidates all validated tasks on a project"""
validated_tasks = Task.query.filter(
Task.project_id == project_id,
Task.task_status == TaskStatus.VALIDATED.value,
).all()
for task in validated_tasks:
task.lock_task_for_validating(user_id)
task.unlock_task(user_id, new_state=TaskStatus.INVALIDATED)
# Reset counters
project = ProjectService.get_project_by_id(project_id)
project.tasks_validated = 0
project.save()
@staticmethod
def validate_all_tasks(project_id: int, user_id: int):
"""Validates all mapped tasks on a project"""
tasks_to_validate = Task.query.filter(
Task.project_id == project_id,
Task.task_status == TaskStatus.MAPPED.value,
).all()
for task in tasks_to_validate:
task.mapped_by = task.mapped_by or user_id # Ensure we set mapped by value
if TaskStatus(task.task_status) not in [
TaskStatus.LOCKED_FOR_MAPPING,
TaskStatus.LOCKED_FOR_VALIDATION,
]:
# Only lock tasks that are not already locked to avoid double lock issue
task.lock_task_for_validating(user_id)
task.unlock_task(user_id, new_state=TaskStatus.VALIDATED)
# Set counters to fully mapped and validated
project = ProjectService.get_project_by_id(project_id)
project.tasks_validated += project.tasks_mapped
project.tasks_mapped = 0
project.save()
@staticmethod
def get_task_mapping_issues(task_to_unlock: dict):
if task_to_unlock["issues"] is None:
return None
# map ValidationMappingIssue DTOs to TaskMappingIssue instances for any issues
# that have count above zero.
return list(
map(
lambda issue_dto: TaskMappingIssue(
issue=issue_dto.issue,
count=issue_dto.count,
mapping_issue_category_id=issue_dto.mapping_issue_category_id,
),
filter(lambda issue_dto: issue_dto.count > 0, task_to_unlock["issues"]),
)
)
@staticmethod
def revert_user_tasks(revert_dto: RevertUserTasksDTO):
"""
Reverts tasks with supplied action to previous state by specific user
:raises ValidatorServiceError
"""
if ProjectAdminService.is_user_action_permitted_on_project(
revert_dto.action_by, revert_dto.project_id
):
query = Task.query.filter(
Task.project_id == revert_dto.project_id,
Task.task_status == TaskStatus[revert_dto.action].value,
)
if TaskStatus[revert_dto.action].value == TaskStatus.BADIMAGERY.value:
query = query.filter(Task.mapped_by == revert_dto.user_id)
else:
query = query.filter(Task.validated_by == revert_dto.user_id)
tasks_to_revert = query.all()
for task in tasks_to_revert:
task = MappingService.undo_mapping(
revert_dto.project_id,
task.id,
revert_dto.user_id,
revert_dto.preferred_locale,
)
else:
raise ValidatorServiceError(
"UserActionNotPermitted- User not permitted to revert tasks"
)