Skip to content

Conversation

@avikam-pagaya
Copy link
Contributor

This fixes the fact that the file is uploaded twice: once to the S3 endpoint provided, and once to the URL specified in the options.
This error was mentioned here: #278

@vrajroham
Copy link
Collaborator

vrajroham commented Feb 12, 2018

@avikam-pagaya I appreciate your contribution. You are are exactly right, file is sent twice but it has some reason. While creating this AWS feature, I intentionally sent the file to server with s3objectlocation as user may need it for any purpose like, thumbnail creation or it could be anything (better to add feature without removing intended behavior).

As I can see, I'm not seeing that this PR is providing the backward compatibility as we are directly removing image from post data. What I suggest, add one more key to awss3 object. Let's say send_file_to_server = true (default) and build a logic around that, so backward compatibility will be achieved.

Thanks

@avikam-pagaya
Copy link
Contributor Author

No problem, I didn't realize it was intended behaviour.
I'd gladly add this possibility.

BTW, did you consider having the transformation needed directly on the s3 object rather than the posted data?

@ozdemir08
Copy link

I am also having trouble with the same issue. I am trying to upload a file to S3 and save its url to my database. It works for small sized files but when I try to upload a file about 100 mb, then I get validation error which is due to this problem.

I am waiting for merge.

@vrajroham
Copy link
Collaborator

@avikam-pagaya @ozdemir08 Your points seems valid. There will very less user base using both the files. I'll create some work around for same and merge this PR.

Thanks

@avikam-pagaya
Copy link
Contributor Author

Hope I didn't step on your toes with this PR, please check out if it's working as you expected.

@dariaedicas
Copy link

any chances this PR will be merged soon?

@vrajroham vrajroham merged commit 36bf26c into rowanwins:master Apr 10, 2018
@vrajroham
Copy link
Collaborator

@avikam-pagaya Thanks for your valuable contribution and I apologise to keep waiting to merge this PR. @dariaedicas Updated component has been published to npm with tag https://github.com/rowanwins/vue-dropzone/releases/tag/v3.1.0

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants