-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Allow Dropzone deal with uploads to S3 #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@avikam-pagaya I appreciate your contribution. You are are exactly right, file is sent twice but it has some reason. While creating this AWS feature, I intentionally sent the file to server with As I can see, I'm not seeing that this PR is providing the backward compatibility as we are directly removing image from post data. What I suggest, add one more Thanks |
|
No problem, I didn't realize it was intended behaviour. BTW, did you consider having the transformation needed directly on the s3 object rather than the posted data? |
|
I am also having trouble with the same issue. I am trying to upload a file to S3 and save its url to my database. It works for small sized files but when I try to upload a file about 100 mb, then I get validation error which is due to this problem. I am waiting for merge. |
|
@avikam-pagaya @ozdemir08 Your points seems valid. There will very less user base using both the files. I'll create some work around for same and merge this PR. Thanks |
|
Hope I didn't step on your toes with this PR, please check out if it's working as you expected. |
|
any chances this PR will be merged soon? |
|
@avikam-pagaya Thanks for your valuable contribution and I apologise to keep waiting to merge this PR. @dariaedicas Updated component has been published to npm with tag https://github.com/rowanwins/vue-dropzone/releases/tag/v3.1.0 Thanks |
This fixes the fact that the file is uploaded twice: once to the S3 endpoint provided, and once to the URL specified in the options.
This error was mentioned here: #278