Issue #13 - cleaning up ivar storage

Remove @synthesize & use self.

Author: rowanj

Classes/git/PBGitRef.h

@@ -20,9 +20,9 @@ extern NSString * const kGitXBranchRefPrefix;
 extern NSString * const kGitXRemoteRefPrefix;
 
 
-@interface PBGitRef : NSObject <PBGitRefish> {
-	NSString* ref;
-}
+@interface PBGitRef : NSObject <PBGitRefish>
+
+@property (nonatomic, strong, readonly) NSString* ref;
 
 // <PBGitRefish>
 - (NSString *) refishName;
@@ -46,6 +46,6 @@ extern NSString * const kGitXRemoteRefPrefix;
 
 + (PBGitRef*) refFromString: (NSString*) s;
 - (PBGitRef*) initWithString: (NSString*) s;
-@property(readonly) NSString* ref;
+
 
 @end

Classes/git/PBGitRef.m

@@ -18,11 +18,12 @@
 NSString * const kGitXBranchRefPrefix = @"refs/heads/";
 NSString * const kGitXRemoteRefPrefix = @"refs/remotes/";
 
+@interface PBGitRef ()
+@property(nonatomic, strong) NSString* ref;
+@end
 
 @implementation PBGitRef
 
-@synthesize ref;
-
 - (NSString *) tagName
 {
 	if (![self isTag])
@@ -44,7 +45,7 @@ - (NSString *) remoteName
 	if (![self isRemote])
 		return nil;
 
-	return (NSString *)[[ref componentsSeparatedByString:@"/"] objectAtIndex:2];
+	return (NSString *)[[self.ref componentsSeparatedByString:@"/"] objectAtIndex:2];
 }
 
 - (NSString *) remoteBranchName
@@ -68,30 +69,30 @@ - (NSString *) type
 
 - (BOOL) isBranch
 {
-	return [ref hasPrefix:kGitXBranchRefPrefix];
+	return [self.ref hasPrefix:kGitXBranchRefPrefix];
 }
 
 - (BOOL) isTag
 {
-	return [ref hasPrefix:kGitXTagRefPrefix];
+	return [self.ref hasPrefix:kGitXTagRefPrefix];
 }
 
 - (BOOL) isRemote
 {
-	return [ref hasPrefix:kGitXRemoteRefPrefix];
+	return [self.ref hasPrefix:kGitXRemoteRefPrefix];
 }
 
 - (BOOL) isRemoteBranch
 {
 	if (![self isRemote])
 		return NO;
 
-	return ([[ref componentsSeparatedByString:@"/"] count] > 3);
+	return ([[self.ref componentsSeparatedByString:@"/"] count] > 3);
 }
 
 - (BOOL) isEqualToRef:(PBGitRef *)otherRef
 {
-	return [ref isEqualToString:[otherRef ref]];
+	return [self.ref isEqualToString:[otherRef ref]];
 }
 
 - (PBGitRef *) remoteRef
@@ -109,7 +110,11 @@ + (PBGitRef*) refFromString: (NSString*) s
 
 - (PBGitRef*) initWithString: (NSString*) s
 {
-	ref = s;
+	self = [super init];
+	if (!self) {
+		return nil;
+	}
+	self.ref = s;
 	return self;
 }
 
@@ -127,14 +132,16 @@ + (BOOL)isKeyExcludedFromWebScript:(const char *)name {
 
 - (NSString *) refishName
 {
-	return ref;
+	return self.ref;
 }
 
 - (NSString *) shortName
 {
-	if ([self type])
-		return [ref substringFromIndex:[[self type] length] + 7];
-	return ref;
+	if ([self type]) {
+		return [self.ref substringFromIndex:[[self type] length] + 7];
+	}
+	
+	return self.ref;
 }
 
 - (NSString *) refishType