Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct and improve Julia definitions #912

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

ararslan
Copy link
Contributor

The Julia definitions here are partially incorrect (we've never had a super keyword, for example) and very out of date.

Still to do:

  • Add more Base types to TYPES
  • Recognize short form function definitions (e.g. f(x) = ...)
  • Fix module prefixed function definitions (e.g. function A.f(...))
  • Highlight macro name definitions like functions
  • Recognize postfix ' adjoint as an operator

Possible:

  • Highlight function and macro calls by context

@dblessing
Copy link
Collaborator

Thanks for this @ararslan. Will you have time to come back to it in the near future?

@ararslan
Copy link
Contributor Author

Hm, not likely, unfortunately. If this looks okay as-is, perhaps it could be merged and I (or others) could address the other points I laid out in separate PRs?

@dblessing dblessing changed the title WIP: Correct and improve Julia definitions Correct and improve Julia definitions Jun 13, 2018
@dblessing
Copy link
Collaborator

@ararslan Sure. I checked there are no errors when viewing the sample. So long as all the keywords/things you removed were never available in Julia (I don't want to create a regression for Julia highlighting)

@dblessing dblessing added the author-action The PR has been reviewed but action by the author is needed label Jun 13, 2018
@ararslan
Copy link
Contributor Author

Yep, I pruned out the stuff that was incorrect or didn't make sense as previously defined.

@ararslan
Copy link
Contributor Author

Thanks for the review! This will improve the Julia highlighting situation on GitLab. :)

@dblessing dblessing merged commit 1a07a7c into rouge-ruby:master Jun 13, 2018
@ararslan ararslan deleted the aa/better-julia branch June 13, 2018 20:32
@ararslan ararslan mentioned this pull request Jun 13, 2018
8 tasks
@ararslan
Copy link
Contributor Author

I've opened #934 to track the remaining items. Thanks again!

@ararslan
Copy link
Contributor Author

@dblessing, do you know how often changes to Rouge are reflected in GitLab? Is it tied to specific versions of GitLab? My company uses Julia heavily on GitLab, so I'm looking forward to seeing these changes go live. 🙂

@dblessing
Copy link
Collaborator

dblessing commented Jun 21, 2018 via email

@lostella
Copy link

lostella commented Jul 18, 2018

Is this going to be included in a new tagged version anytime soon? I would really love to use it. Or is there any way one can use master in a Gemfile?

Edit: maybe this.

@dblessing
Copy link
Collaborator

Yes @lostella. Quite soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-action The PR has been reviewed but action by the author is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants