-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct and improve Julia definitions #912
Conversation
Thanks for this @ararslan. Will you have time to come back to it in the near future? |
Hm, not likely, unfortunately. If this looks okay as-is, perhaps it could be merged and I (or others) could address the other points I laid out in separate PRs? |
@ararslan Sure. I checked there are no errors when viewing the sample. So long as all the keywords/things you removed were never available in Julia (I don't want to create a regression for Julia highlighting) |
Yep, I pruned out the stuff that was incorrect or didn't make sense as previously defined. |
Thanks for the review! This will improve the Julia highlighting situation on GitLab. :) |
I've opened #934 to track the remaining items. Thanks again! |
@dblessing, do you know how often changes to Rouge are reflected in GitLab? Is it tied to specific versions of GitLab? My company uses Julia heavily on GitLab, so I'm looking forward to seeing these changes go live. 🙂 |
I plan to release Rouge in the next few weeks. Then I will submit a merge
request to GitLab to update the version. So it should be available on
GitLab.com in early July and released in 11.1 on July 22.
…On Thu, Jun 21, 2018 at 4:27 PM Alex Arslan ***@***.***> wrote:
@dblessing <https://github.com/dblessing>, do you know how often changes
to Rouge are reflected in GitLab? Is it tied to specific versions of
GitLab? My company uses Julia heavily on GitLab, so I'm looking forward to
seeing these changes go live. 🙂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#912 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACSKlCkyvjMzevn5dJXzoafHZGJ6IP8Dks5t_A_RgaJpZM4UDsMi>
.
|
Is this going to be included in a new tagged version anytime soon? I would really love to use it. Or is there any way one can use Edit: maybe this. |
Yes @lostella. Quite soon. |
The Julia definitions here are partially incorrect (we've never had a
super
keyword, for example) and very out of date.Still to do:
TYPES
f(x) = ...
)function A.f(...)
)'
adjoint as an operatorPossible: