Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handlebars support #737 #899

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Better handlebars support #737 #899

merged 2 commits into from
Jul 18, 2019

Conversation

jlemaes
Copy link
Contributor

@jlemaes jlemaes commented Apr 22, 2018

I added better handlebars support
Fix for issue #737
Also adds ~ support which is needed for whitespace control

@dblessing
Copy link
Collaborator

Thanks @jlemaes. Will you please add an example or two in spec/visuals/handlebars that will help me see how this PR improves highlighting?

@jlemaes
Copy link
Contributor Author

jlemaes commented Jun 13, 2018

@dblessing I already added examples in spec/visual/samples/handlebars. Should I add these somewhere else?

@dblessing
Copy link
Collaborator

@jlemaes 🤦‍♂️ What the heck? Apparently I can't scroll today? Sorry about that.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jun 17, 2019
@pyrmont pyrmont merged commit 1842a0d into rouge-ruby:master Jul 18, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jul 18, 2019

@jlemaes I'm sorry it took so long to get this merged in but it's finally done! This should be available in the next release of Rouge (3.7.0) which will come out next Tuesday. Thank you for improving Rouge! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review The PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants