Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Varnish lexer #365

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Add a Varnish lexer #365

merged 1 commit into from
Feb 10, 2020

Conversation

julp
Copy link
Contributor

@julp julp commented Dec 27, 2015

Proposal for a Varnish (VCL) lexer

@jneen jneen added lexer-request A request for a lexer to be developed. needs-review The PR needs to be reviewed labels Jun 2, 2016
lucidbee pushed a commit to BonsaiAI/rouge that referenced this pull request Mar 16, 2017
@gfx
Copy link
Member

gfx commented Jun 8, 2017

I've looked at it based on the master (v2.1.0), and it works well.

LGTM.

cc: @jneen

@gfx
Copy link
Member

gfx commented Jun 8, 2017

There are examples available from:

@blckct
Copy link

blckct commented Mar 13, 2018

I could use that. Is there something that needs to be done to get this accepted?

@gfx
Copy link
Member

gfx commented Feb 10, 2020

Sorry to be late, but now I'll merge this PR.

@pyrmont HI! I'd like to merge this PR because I am now interested in Varnish.

@gfx gfx self-assigned this Feb 10, 2020
@gfx
Copy link
Member

gfx commented Feb 10, 2020

Note: I'll fix some warnings after merging it.

done at e6dd5b5

@gfx gfx merged commit 8abe647 into rouge-ruby:master Feb 10, 2020
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lexer-request A request for a lexer to be developed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants