Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandon ruby 19 #269

Closed
wants to merge 2 commits into from
Closed

Abandon ruby 19 #269

wants to merge 2 commits into from

Conversation

rumpelsepp
Copy link
Contributor

Ruby 1.9 is dead!
Ruby 2.2 is out there, so let's adjust travis ci!

@onebree
Copy link

onebree commented Jun 13, 2015

Would this affect the user of the library if they have Ruby 1.9?

@jneen
Copy link
Member

jneen commented Jun 13, 2015

@onebree hopefully not! it just means we don't run tests on 1.9 anymore, so i can't guarantee that it won't break in the future.

@jneen
Copy link
Member

jneen commented Jun 13, 2015

that said, I don't think we're using any 2.0-specific features, so I don't see why you wouldn't be able to use it anyways.

@mojavelinux
Copy link
Contributor

I agree with the addition of Ruby 2.2 to the Travis CI build, but I don't see a reason to drop 1.9.3 until there's a compelling reason to code against the Ruby 2 APIs. Rouge is a pretty fundamental library, so we want to be sure that no downstream programs still have a Ruby 1.9.3 requirement. Otherwise Rouge forces that decision, which I don't think is appropriate. I'm still seeing lots of machines with Ruby 1.9.3 these days, so it may not be supported, but it's not dead yet.

@rumpelsepp
Copy link
Contributor Author

I had splitted my pull request into two commits; so maybe @jneen could apply only this patch.

@jneen
Copy link
Member

jneen commented Sep 10, 2015

I ended up doing this manually. Thanks!

@jneen jneen closed this Sep 10, 2015
@jneen
Copy link
Member

jneen commented Sep 10, 2015

(to clarify: still supporting 1.9.3, but also testing 2.2)

@rumpelsepp
Copy link
Contributor Author

👍

1 similar comment
@mojavelinux
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants