Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Duplicate identity Keyword in YANG Lexer #1499

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

gribok
Copy link
Contributor

@gribok gribok commented Apr 13, 2020

I have found a duplicate identity keyword and removed it.

@pyrmont pyrmont self-assigned this Apr 13, 2020
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Apr 14, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Apr 14, 2020

@gribok I thought the best way to eliminate this kind of thing happening again is to alphabetise all of the keyword lists. I don't see any other duplicates but let me know what you think.

@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Apr 14, 2020
@gribok
Copy link
Contributor Author

gribok commented Apr 14, 2020

@gribok I thought the best way to eliminate this kind of thing happening again is to alphabetise all of the keyword lists. I don't see any other duplicates but let me know what you think.

Make sense to alphabetise the keyword lists. Thanks for support - you can merge it.

@pyrmont pyrmont merged commit 8b6f2b5 into rouge-ruby:master Apr 14, 2020
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Apr 14, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Apr 14, 2020

@gribok Great! Merged!

mattt pushed a commit to NSHipster/rouge that referenced this pull request May 21, 2020
This commit alphabetises all of the keywords and removes a duplicate
entry for `identity`.

Co-authored-by: Michael Camilleri <mike@inqk.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants