Add support for optional chaining operator to TypeScript lexer #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codebutler Does this look all right to you? Looking good for me.
|
|
Looks great!! Webstorm for comparison:
|
|
@codebutler Neat! Sorry it took a while for what is, in the end, quite a simple fix. This will be part of the next release of Rouge—that's scheduled for release on Tuesday 14 April :) |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 21, 2020
…-ruby#1475) TypeScript has added support for the optional chaining operator `?.` as of version 3.7. This commit adds support by prepending a rule to the `:root` state of the TypeScript lexer. Eventually, when JavaScript adopts the operator, the rule should be moved into the `:root` state there and removed from this lexer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1420, TypeScript had added support for the optional chaining operator
?.. This PR adds support by prepending a rule to the:rootstate. Eventually, when JavaScript adopts the operator, the rule should be moved into the:rootstate there and removed from this lexer.This closes #1420.