fix number literals in the Ruby lexer #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
approved these changes
Mar 8, 2020
pyrmont
added
the
author-action
|
That's all for the time being. Thanks! |
pyrmont
removed
the
author-action
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 21, 2020
Ruby supports number literals that include `_` and that include exponents. This commit adds support for this syntax to the Ruby lexer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a problem that the following number literals are not tokenized properly:
1e231_2.3_4I think we'd better add the common utility for such common-but-complex tokens.