Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lexer datastudio #1453

Merged
merged 8 commits into from
Mar 31, 2020
Merged

Lexer datastudio #1453

merged 8 commits into from
Mar 31, 2020

Conversation

BastienDurel
Copy link
Contributor

Here is a lexer for datastudio scripting language

@pyrmont pyrmont self-assigned this Mar 8, 2020
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Mar 8, 2020
pyrmont
pyrmont suggested changes Mar 8, 2020
View reviewed changes
lib/rouge/lexers/datastudio.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/datastudio.rb Show resolved Hide resolved
lib/rouge/lexers/datastudio.rb Show resolved Hide resolved
lib/rouge/lexers/datastudio.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/datastudio.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/datastudio.rb Outdated Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Mar 8, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Mar 8, 2020

Oh, and I'm sorry for not saying this in the previous message but thanks for contributing your first PR to Rouge! It looks very good :D

@pyrmont pyrmont added needs-review The PR needs to be reviewed and removed author-action The PR has been reviewed but action by the author is needed labels Mar 24, 2020
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Mar 24, 2020
@pyrmont pyrmont merged commit 06ee54e into rouge-ruby:master Mar 31, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Mar 31, 2020

@BastienDurel Thanks for the changes. This will be part of the next release of Rouge—that's scheduled for Tuesday 14 April :)

@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Mar 31, 2020
@BastienDurel
Copy link
Contributor Author

Thanks ! I will be able to remove the direct git ref in my Gemfile :)

mattt pushed a commit to NSHipster/rouge that referenced this pull request May 21, 2020
@BastienDurel @mattt
Add Datastudio lexer (rouge-ruby#1453)
07f2b0e 
This commit adds a lexer for Datastudio.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrmont pyrmont pyrmont approved these changes

Assignees

@pyrmont pyrmont

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BastienDurel @pyrmont