Add a lexer for Ada 2012. #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements Ada as described in the [Consolidated Ada 2012 Language Reference Manual](http://ada-auth.org/standards/ada12_w_tc1.html). Follow the pygments example in terms of mime-type and file extensions detected, but allow for full Unicode identifiers. Ada has specific rules about the use of underscores in identifiers and number literals, and we flag any errors. Resolves #824.
pyrmont
reviewed
Jul 10, 2019
pyrmont
added
author-action
The rule entering state :libunit_name was incorrectly classifying whitespace as Keyword::Namespace in `limited with`. Add a spec to make sure this is marked as Text. In the :libunit_name state, detect keywords that shouldn't be there and use those to recover quickly from the incorrectly entered state. This recovery is more robust that the previous ping-pong with :libunit_sep, so merge that state into libunit_name for simplicity. Add specs to make sure we're recovering well.
|
Thanks for reviewing, @pyrmont! I've added a new commit which addresses your review comments and also gets rid of the |
|
@stoklund Thanks for taking the time to submit such a good PR! It's great to have support for Ada in Rouge :) |
pyrmont
removed
author-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements Ada as described in the Consolidated Ada 2012 Language
Reference Manual.
Follow the pygments example in terms of mime-type and file extensions
detected, but allow for full Unicode identifiers. Ada has specific rules
about the use of underscores in identifiers and number literals, and we
flag any errors.
Resolves #824.
I'm aware of the other Ada PR, #1021. I think this attempt is more complete with some significant differences:
package Standardare not keywords, so I'm marking them, asName.Builtin.'x'.I'd be happy to take notes from @btmalone.