Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transliteration in Perl lexer #1250

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

labster
Copy link
Contributor

@labster labster commented Jul 6, 2019

Add support for tr/// and y/// by hitching along with s/// from
substitutions. Also reduce the number of substitution rules by
taking an arbitrary delimiter, as with match below, which has the
benefit of matching more substitutions correctly.

Also move DATA down to live with END, because it also
signals the end of parsing.

Add support for tr/// and y/// by hitching along with s/// from
substitutions.  Also reduce the number of substitution rules by
taking an arbitrary delimiter, as with match below, which has the
benefit of matching more substitutions correctly.

Also move __DATA__ down to live with __END__, because it also
signals the end of parsing.
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jul 8, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jul 8, 2019

@labster Thanks for the submission! Will have a look at this in the next couple of days and get back to you with any comments :)

@pyrmont
Copy link
Contributor

pyrmont commented Jul 9, 2019

@labster Looks good to me! Will merge in.

@pyrmont pyrmont merged commit 5e7fb25 into rouge-ruby:master Jul 9, 2019
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants