shell: balance parentheses inside $(...) interpolation #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 25, 2019 09:47
Fixes #812 To lex correctly, we must make sure that interpolation does not end until the balanced parenthesis. For this we need to use the state stack to track the parenthesis depth.
|
I also noticed a bug in the visual spec relating to backslash escapes in heredocs. Basically the heredoc regex was skipping over backslashes before handing them to the |
pyrmont
added a commit
to pyrmont/rouge
that referenced
this pull request
Jun 25, 2019
The update to the Shell lexer made as a result of rouge-ruby#1216 should have included an update to the PowerShell lexer. This is because the Shell lexer renamed the `:paren` state. Since the PowerShell lexer relies on this state, it needed to be updated to refer to the new state. This commit does that.
pyrmont
added a commit
that referenced
this pull request
Jun 25, 2019
The update to the Shell lexer made as a result of #1216 should have included an update to the PowerShell lexer. This is because the Shell lexer renamed the `:paren` state. Since the PowerShell lexer relies on this state, it needed to be updated to refer to the new state. This commit does that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #812
To lex correctly, we must make sure that interpolation does not end
until the balanced parenthesis. For this we need to use the state stack
to track the parenthesis depth.