Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development environment documentation #1212

Merged
merged 5 commits into from
Jun 21, 2019

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Jun 21, 2019

This commit adds a document about how to set up a development environment for Rouge.

This commit adds a document about how to set up a development
environment for Rouge.
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jun 21, 2019
Copy link
Contributor

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions..

docs/DevEnvironment.md Outdated Show resolved Hide resolved
docs/DevEnvironment.md Outdated Show resolved Hide resolved
docs/DevEnvironment.md Show resolved Hide resolved
docs/DevEnvironment.md Outdated Show resolved Hide resolved
docs/DevEnvironment.md Outdated Show resolved Hide resolved
docs/DevEnvironment.md Outdated Show resolved Hide resolved
@pyrmont pyrmont merged commit 0aada94 into rouge-ruby:master Jun 21, 2019
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Jun 21, 2019
@gmckeown
Copy link
Contributor

Really handy, thank-you for this. The only issue I came across was that I'm running Ruby on a remote Linux box, so I want the webserver launched by bundle exec rackup to listen on 0.0.0.0 rather than localhost. The way I found to do this was RACK_ENV=deployment bundle exec rackup. No idea if this is the right way...

@aaroneg
Copy link
Contributor

aaroneg commented Jun 26, 2019 via email

@gmckeown
Copy link
Contributor

You can also do -o 0.0.0.0 if memory serves

Yep, just checked and that works for me as well: bundle exec rackup -o 0.0.0.0

@pyrmont
Copy link
Contributor Author

pyrmont commented Jun 29, 2019

It might be worth updating the documentation to explain this option. I do my development on a remote server and use this method (together with setting a different port to one that's open on my firewall) but didn't think there were many other people out there with the same setup. Good to know I'm not alone! :)

@pyrmont pyrmont deleted the feature.docs-rouge-dev-env branch January 8, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants