-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run rake tasks with interpreter warnings enabled #1177
Conversation
He wasn't kidding about it being noisy, huh? |
Hehe.. yeah. 😃 |
I thought it simpler to convert |
I've also played around with turning on Ruby's warnings as this PR does. #1180 helps reduce the number somewhat but there's still a lot. I'm having a look at how feasible it is to fix them by hand (maybe too time consuming and not worth the effort while so many substantive PRs are still outstanding). |
I'd be happy to take a crack at fixing some of the warnings once you get to a stopping point. |
@mojavelinux Thanks :) I'll let you know how I go. |
I volunteer to help with this if @mojavelinux needs a hand.. |
I'm okay with whatever it takes to keep the boat afloat.. 😛 |
...and be a good Ruby citizen. |
Opened #1184 to remove all those |
@pyrmont I'm sticking to the disable warnings by default stance for now. Once we've reduced the warnings to a manageable level, I'll submit a PR to make it enabled by default.. |
👍 The important point is that they're simple to enable ;) |
Thanks Dan 😃 |
Reaction to #1174 (comment)
/cc @mojavelinux