-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BrainF*ck Language #1037
Added BrainF*ck Language #1037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for submitting your lexer. I'm trying to help clean out the pull request backlog... I've commented on a few things in your lexer. It'd be great if you take a look, and I'm sure we can get it tidied up so it can be included.
After the useful comments of @vidarh I decided to revisit the BrainFuck lexer. I have improved my knowledge of Ruby during this time so I wrote a much better lexer (improving a lot its complexity). It's all written in |
@espositoandrea Wow that was a quick turnaround. (Don't worry about the CI failure; it's broken for all commits at the moment - we can rerun that once its fixed). |
@espositoandrea Just one more small nitpick: Can you fix the indentation so it's in line with the others? (2 spaces per indentation level) |
@vidarh sure! Done! |
Hi there, @espositoandrea :) I posted a suggested change to your branch as a PR. I might have screwed it up by rebasing against master first. If I did, feel free to just copy and paste into your own file! |
Hi, @pyrmont. I've merged your PR. |
Thanks for contributing to Rouge! :) |
I added a lexer for the BrainF*ck language.
This was my first time using Ruby, so I think it's a pretty dirty code, but it works. It can be improved in many ways, but it's a starting point.