Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 2+ HTML bindings templates are highlighted as errors. #725

Closed
el-dot opened this issue Jul 18, 2017 · 2 comments
Closed

Angular 2+ HTML bindings templates are highlighted as errors. #725

el-dot opened this issue Jul 18, 2017 · 2 comments

Comments

@el-dot
Copy link

el-dot commented Jul 18, 2017

<app-my #my></app-my> and <div [class.test]="expression"></div> and <button (click)="fun()"></button> and <input [(value)]="data"></input>.
All above binding are highlighted as errors on GitLab which uses rouge as far as I know.
Sorry, if it's my fault, and I only need some additional angularx configuration, but I couldn't find any syntax hightlight for angular2+ on README etc.

EDIT:// And anyway seems like [value]="exp" and so are valid html tags :)

@nicktobolski
Copy link

I would loved to see this fixed. We're using Angular for a big project at my company and Gitlab's failing to diff angular templates is a nuisance and an impediment to progress.

Maybe an Angular team engineer would be interesting in help out?

@pyrmont
Copy link
Contributor

pyrmont commented Jul 21, 2019

#907 has been merged into master and should address this. Sorry it took so long! >_<

@pyrmont pyrmont closed this as completed Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants