Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
I added code to fix all the problems from there, except the last line about exporting in function
toDataURL
to formats other thanjpeg
. There are 2 reasons for that:jpeg
andpng
. For example, Chrome even supportswebp
, see the docs.jpeg
. It does not matter what kind of image the user selects: it may be any format supported by the browser, but after uploading we will have alwaysjpeg
, i.e. auto conversion is performed. I think it's logical. Alternatively, we could add a new option that would define the output format in which the JS code saves the final image. But such option is beyond the current PR.