Skip to content
This repository was archived by the owner on Aug 11, 2023. It is now read-only.

Commit c746aed

Browse files
authored
Merge pull request #242 from jubeira/fix/node_shutdown
Fix: avoid exceptions on node shutdown
2 parents d151b2b + 136b175 commit c746aed

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

rosjava/src/main/java/org/ros/internal/node/DefaultNode.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@
3939
import org.ros.internal.node.service.ServiceFactory;
4040
import org.ros.internal.node.service.ServiceIdentifier;
4141
import org.ros.internal.node.service.ServiceManager;
42-
import org.ros.internal.node.topic.DefaultPublisher;
43-
import org.ros.internal.node.topic.DefaultSubscriber;
4442
import org.ros.internal.node.topic.PublisherFactory;
4543
import org.ros.internal.node.topic.SubscriberFactory;
4644
import org.ros.internal.node.topic.TopicDeclaration;
@@ -405,6 +403,7 @@ public void shutdown() {
405403
// NOTE(damonkohler): We don't want to raise potentially spurious
406404
// exceptions during shutdown that would interrupt the process. This is
407405
// simply best effort cleanup.
406+
slaveServer.shutdown();
408407
topicParticipantManager.shutdown();
409408
for (ServiceServer<?, ?> serviceServer : serviceManager.getServers()) {
410409
try {

rosjava_helpers/src/main/java/org/ros/helpers/ParameterLoaderNode.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
public class ParameterLoaderNode extends AbstractNodeMain {
4141

4242
public static final String NODE_NAME = "parameter_loader";
43-
private final List<LoadedResource> params = new ArrayList<>();
43+
private final List<LoadedResource> params = new ArrayList<LoadedResource>();
4444
private Log log;
4545

4646
/**
@@ -57,6 +57,7 @@ private void addSingleYmlInput(InputStream ymlInputStream, String namespace) {
5757
this.params.add(new LoadedResource((new Yaml()).load(ymlInputStream), namespace));
5858
}
5959

60+
@SuppressWarnings("unchecked")
6061
private void addParams(ParameterTree parameterTree, String namespace, Map<String, Object> params) {
6162
for (Map.Entry<String, Object> e : params.entrySet()) {
6263
String fullKeyName = namespace + "/" + e.getKey();

0 commit comments

Comments
 (0)