Skip to content
This repository was archived by the owner on Nov 9, 2022. It is now read-only.

Commit 5b5afb4

Browse files
author
Juan Ignacio Ubeira
authored
Merge pull request #35 from jubeira/gradle-3-5-1
Gradle upgrade: 3.5.1
2 parents d04dfde + f79ed57 commit 5b5afb4

File tree

10 files changed

+18
-13
lines changed

10 files changed

+18
-13
lines changed

cmake/rosjava.cmake.em

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ endmacro()
6767
# RosJava Package
6868
##############################################################################
6969
# Calls the gradle wrapper to compile just the package
70-
# that it is called in with install and installApp targets.
70+
# that it is called in with install and installDist targets.
7171
macro(catkin_rosjava_setup)
7272
catkin_rosjava_env_setup()
7373
find_gradle()

src/rosjava_build_tools/create_android_project.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import argparse
1212
import subprocess
1313
import shutil
14+
import exceptions
1415

1516
# local imports
1617
import utils
@@ -71,6 +72,10 @@ def actually_create_android_project(package_name, target_version, java_package_n
7172
except subprocess.CalledProcessError:
7273
print("Error")
7374
raise subprocess.CalledProcessError("failed to create android project.")
75+
except exceptions.OSError as e:
76+
print("OS error" + str(e))
77+
raise exceptions.OSError()
78+
7479
# This is in the old form, let's shovel the shit around to the new form
7580
utils.mkdir_p(os.path.join(path, 'src', 'main', 'java'))
7681
os.remove(os.path.join(path, 'local.properties'))

src/rosjava_build_tools/create_rosjava_project.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,8 @@ def add_tasks_to_cmake_setup(tasks):
175175
gradle_tasks = set([])
176176
if rosjava_setup_string.find("publish") == -1:
177177
gradle_tasks.add("publish")
178-
if rosjava_setup_string.find("installApp") == -1:
179-
gradle_tasks.add("installApp")
178+
if rosjava_setup_string.find("installDist") == -1:
179+
gradle_tasks.add("installDist")
180180
gradle_tasks |= set(tasks)
181181
console.pretty_print(' File : ', console.cyan)
182182
console.pretty_println('CMakeLists.txt (gradle task update)', console.yellow)
@@ -236,7 +236,7 @@ def create_rosjava_project():
236236
author = args.author
237237
create_rosjava_project_common(args, 'rosjava_project')
238238
create_talker_listener_classes(project_name, 'rosjava_project', author)
239-
add_tasks_to_cmake_setup(['installApp', 'publish'])
239+
add_tasks_to_cmake_setup(['installDist', 'publish'])
240240

241241

242242
def create_rosjava_library_project():
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
This is not installed, but it gets used to generate the gradle wrapper for a project.
22

3-
It is currently the gradle wrapper supporting gradle 2.14.1
3+
It is currently the gradle wrapper supporting gradle 3.5.1
Binary file not shown.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Wed Feb 11 20:39:17 KST 2015
1+
#Fri Jan 26 13:47:21 ART 2018
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=http\://services.gradle.org/distributions/gradle-2.14.1-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-3.5.1-bin.zip

src/rosjava_build_tools/templates/android_package/build.gradle.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
task wrapper(type: Wrapper) {
18-
gradleVersion = '2.14.1'
18+
gradleVersion = '3.5.1'
1919
}
2020

2121
buildscript {

src/rosjava_build_tools/templates/rosjava_package/CMakeLists.txt.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ project(%(repo_name)s)
1212
find_package(catkin REQUIRED rosjava_build_tools)
1313

1414
# Set the gradle targets you want catkin's make to run by default, e.g.
15-
# catkin_rosjava_setup(installApp)
15+
# catkin_rosjava_setup(installDist)
1616
# Note that the catkin_create_rosjava_xxx scripts will usually automatically
1717
# add tasks to this for you when you create subprojects.
1818
catkin_rosjava_setup()

src/rosjava_build_tools/templates/rosjava_package/build.gradle.in

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
task wrapper(type: Wrapper) {
18-
gradleVersion = '2.14.1'
18+
gradleVersion = '3.5.1'
1919
}
2020

2121
buildscript {
@@ -59,9 +59,9 @@ subprojects {
5959

6060
install: deploys jar's to MavenLocal() (i.e. ~/.m2/repository)
6161
publish : deploys jar's to devel/share/maven
62-
installApp : assembles java apps in the _subproject_/build directories.
62+
installDist : assembles java apps in the _subproject_/build directories.
6363

64-
Note that these are dependent on the type of project (e.g. installApp is only valid for
64+
Note that these are dependent on the type of project (e.g. installDist is only valid for
6565
java binary subprojects, while publish is only added once a subproject is included.
6666
If you're using catkin_make, this is not important, since it will use the task list specified
6767
in CMakeLists.txt

src/rosjava_build_tools/templates/rosjava_project/build.gradle.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* the License.
1515
*/
1616

17-
/* This plugin is necessary for creating installApp tasks (i.e. executables) */
17+
/* This plugin is necessary for creating installDist tasks (i.e. executables) */
1818
apply plugin: 'application'
1919
mainClassName = 'org.ros.RosRun'
2020

0 commit comments

Comments
 (0)