Skip to content

Commit bcb7615

Browse files
authored
Bugfixes on Python code generation (PickNikRobotics#152)
* Fix raising of validation error * Fix inverse logic of 'unique' validator
1 parent 487e7da commit bcb7615

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

generate_parameter_library_py/generate_parameter_library_py/python_convertions.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def get_func_signature(self, function_name: str, base_type: str) -> str:
9292

9393
@typechecked
9494
def initialization_fail_validation(self, param_name: str) -> str:
95-
return f"raise InvalidParameterValueException('Invalid value set during initialization for parameter {param_name}: ' + validation_result)"
95+
return f"raise InvalidParameterValueException('{param_name}',param.value, 'Invalid value set during initialization for parameter {param_name}: ' + validation_result)"
9696

9797
@typechecked
9898
def initialization_pass_validation(self, param_name: str) -> str:

generate_parameter_library_py/generate_parameter_library_py/python_validators.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def one_of(param, values):
7171

7272
# Array validators
7373
def unique(param):
74-
if not len(set(param.value)) != len(param.value):
74+
if len(set(param.value)) != len(param.value):
7575
return f"Parameter '{param.name}' must only contain unique values"
7676
return ""
7777

0 commit comments

Comments
 (0)