replace create_parameter with declare_parameter

Signed-off-by: William Woodall <william@osrfoundation.org>

Author: wjwwood

test_rclcpp/test/parameter_fixtures.hpp

@@ -29,13 +29,13 @@ const double test_epsilon = 1e-6;
 
 void declare_test_parameters(std::shared_ptr<rclcpp::Node> node)
 {
-  node->create_parameter("foo");
-  node->create_parameter("bar");
-  node->create_parameter("barstr");
-  node->create_parameter("baz");
-  node->create_parameter("foo.first");
-  node->create_parameter("foo.second");
-  node->create_parameter("foobar");
+  node->declare_parameter("foo");
+  node->declare_parameter("bar");
+  node->declare_parameter("barstr");
+  node->declare_parameter("baz");
+  node->declare_parameter("foo.first");
+  node->declare_parameter("foo.second");
+  node->declare_parameter("foobar");
 }
 
 void set_test_parameters(

test_rclcpp/test/test_local_parameters.cpp

@@ -110,12 +110,12 @@ class ParametersAsyncNode : public rclcpp::Node
   ParametersAsyncNode()
   : Node("test_local_parameters_async_with_callback")
   {
-    this->create_parameter("foo");
-    this->create_parameter("bar");
-    this->create_parameter("barstr");
-    this->create_parameter("baz");
-    this->create_parameter("foobar");
-    this->create_parameter("barfoo");
+    this->declare_parameter("foo");
+    this->declare_parameter("bar");
+    this->declare_parameter("barstr");
+    this->declare_parameter("baz");
+    this->declare_parameter("foobar");
+    this->declare_parameter("barfoo");
 
     parameters_client_ =
       std::make_shared<rclcpp::AsyncParametersClient>(this);
@@ -167,12 +167,12 @@ TEST(CLASSNAME(test_local_parameters, RMW_IMPLEMENTATION), local_async_with_call
 TEST(CLASSNAME(test_local_parameters, RMW_IMPLEMENTATION), helpers) {
   if (!rclcpp::ok()) {rclcpp::init(0, nullptr);}
   auto node = rclcpp::Node::make_shared("test_parameters_local_helpers");
-  node->create_parameter("foo");
-  node->create_parameter("bar");
-  node->create_parameter("barstr");
-  node->create_parameter("baz");
-  node->create_parameter("foobar");
-  node->create_parameter("barfoo");
+  node->declare_parameter("foo");
+  node->declare_parameter("bar");
+  node->declare_parameter("barstr");
+  node->declare_parameter("baz");
+  node->declare_parameter("foobar");
+  node->declare_parameter("barfoo");
 
   auto parameters_client = std::make_shared<rclcpp::SyncParametersClient>(node);
   if (!parameters_client->wait_for_service(20s)) {
@@ -284,12 +284,12 @@ TEST(CLASSNAME(test_local_parameters, RMW_IMPLEMENTATION), helpers) {
 TEST(CLASSNAME(test_local_parameters, RMW_IMPLEMENTATION), get_from_node_primitive_type) {
   if (!rclcpp::ok()) {rclcpp::init(0, nullptr);}
   auto node = rclcpp::Node::make_shared("test_parameters_local_helpers");
-  node->create_parameter("foo");
-  node->create_parameter("bar");
-  node->create_parameter("barstr");
-  node->create_parameter("baz");
-  node->create_parameter("foobar");
-  node->create_parameter("barfoo");
+  node->declare_parameter("foo");
+  node->declare_parameter("bar");
+  node->declare_parameter("barstr");
+  node->declare_parameter("baz");
+  node->declare_parameter("foobar");
+  node->declare_parameter("barfoo");
 
   auto parameters_client = std::make_shared<rclcpp::SyncParametersClient>(node);
   if (!parameters_client->wait_for_service(20s)) {
@@ -357,12 +357,12 @@ TEST(CLASSNAME(test_local_parameters, RMW_IMPLEMENTATION), get_from_node_variant
   using rclcpp::Parameter;
 
   auto node = rclcpp::Node::make_shared("test_parameters_local_helpers");
-  node->create_parameter("foo");
-  node->create_parameter("bar");
-  node->create_parameter("barstr");
-  node->create_parameter("baz");
-  node->create_parameter("foobar");
-  node->create_parameter("barfoo");
+  node->declare_parameter("foo");
+  node->declare_parameter("bar");
+  node->declare_parameter("barstr");
+  node->declare_parameter("baz");
+  node->declare_parameter("foobar");
+  node->declare_parameter("barfoo");
 
   auto parameters_client = std::make_shared<rclcpp::SyncParametersClient>(node);
   if (!parameters_client->wait_for_service(20s)) {
@@ -422,7 +422,7 @@ TEST(CLASSNAME(test_local_parameters, RMW_IMPLEMENTATION), get_parameter_or) {
   using rclcpp::Parameter;
 
   auto node = rclcpp::Node::make_shared("test_parameters_get_parameter_or");
-  node->create_parameter("foo");
+  node->declare_parameter("foo");
   auto set_parameters_results = node->set_parameters({
     Parameter("foo", 2),
   });
@@ -493,8 +493,8 @@ TEST(CLASSNAME(test_local_parameters, RMW_IMPLEMENTATION), set_parameter_if_not_
   using rclcpp::Parameter;
 
   auto node = rclcpp::Node::make_shared("test_parameters_set_parameter_if_not_set");
-  node->create_parameter("foo");
-  node->create_parameter("bar");
+  node->declare_parameter("foo");
+  node->declare_parameter("bar");
 
   auto set_parameters_results = node->set_parameters({
     Parameter("foo", 2),