Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make C++ typesupport use rosidl_typesupport_interface #684

Open
sloretz opened this issue Jun 11, 2022 · 0 comments
Open

Make C++ typesupport use rosidl_typesupport_interface #684

sloretz opened this issue Jun 11, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@sloretz
Copy link
Contributor

sloretz commented Jun 11, 2022

ros2/rosidl_typesupport#114 adds rosidl_typesupport_interface implementations for actions and services. It was already implemented for messages.

Right now rosidl_typesupport_cpp is defining get_action|service|message_type_support_handle<T>() in a .cpp file. I think it should be defined in a header file generated by rosidl_generator_cpp, and it should call the rosidl_typesupport_interface function to get the handle. That makes the rosidl_typesupport_interface APIs the authoritative source with the C++ function being useful sugar on top of it.

Links

Defines rosidl_typesupport_cpp::get_action_type_support_handle() here
Defines rosidl_typesupport_cpp::get_service_type_support_handle() here
Defines rosidl_typesupport_cpp::get_message_type_support_handle() here

@sloretz sloretz added the enhancement New feature or request label Jun 11, 2022
@jacobperron jacobperron removed their assignment May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants