Make rosbag2 nodes locally unique by suffixing with PID #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
emersonknapp
requested review from
gbiggs,
jhdcs and
MichaelOrlov
and removed request for
a team
emersonknapp
changed the title
8 tasks
MichaelOrlov
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
@emersonknapp In general LGTM.
I am thinking that now the node name became autogenerated by default and it will be difficult to figure out what it is to send service requests from the command line.
It would be very handful to output the final node_name to the LOG_INFO() stream at least.
| @@ -148,6 +148,14 @@ def add_standard_reader_args(parser: ArgumentParser) -> None: | |||
| 'By default attempts to detect automatically - use this argument to override.') | |||
|
|
|||
|
|
|||
| def add_standard_node_args(parser: ArgumentParser, prefix: str) -> None: | |||
| """Add arguments for for verbs that create a Node.""" | |||
There was a problem hiding this comment.
Suggested change
| """Add arguments for for verbs that create a Node.""" | |
| """Add arguments for verbs that create a Node.""" |
Nitpick, need to remove extra "for".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #425
Copies same approach from https://github.com/AAlon/ros2cli/blob/master/ros2cli/ros2cli/node/direct.py#L37
Adds a
--node-nameoption to all verbs that create a ros2 node. Defaults toprefix_PIDby using Pythonos.getpid(). This way all running players/recorders will have locally unique names by default. "Locally" because within the local machine the PID will be unique, but may not be within a multi-machine system. In this case it probably pays to be explicit anyways, and the--node-nameoption allows for that.