Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails if you don't have fastrtps #136

Closed
ivanpauno opened this issue Jun 25, 2019 · 1 comment · Fixed by #137
Closed

Build fails if you don't have fastrtps #136

ivanpauno opened this issue Jun 25, 2019 · 1 comment · Fixed by #137
Assignees
Labels
bug Something isn't working

Comments

@ivanpauno
Copy link
Member

ivanpauno commented Jun 25, 2019

The building of rosbag2_converter_default_plugins is failing not quietly when you don't have rmw_fastrtps_cpp. I think that's not ok, you should be able to build ros2 without it (e.g.: only with opensplice or connext).

Failing CI builds with only opensplice (from comment):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Further info:

The problem is here:

if(BUILD_TESTING)
find_package(ament_cmake_gmock REQUIRED)
find_package(ament_lint_auto REQUIRED)
find_package(rcutils REQUIRED)
find_package(rmw_fastrtps_cpp REQUIRED)

The build is only failing when BUILD_TESTING=1, but that's usual.

@ivanpauno ivanpauno changed the title Build fail if you don't have fastrtps Build fails if you don't have fastrtps Jun 25, 2019
@dirk-thomas
Copy link
Member

dirk-thomas commented Jul 31, 2019

@Karsten1987 can you please address this since it makes building without FastRTPS more effort.

@dirk-thomas dirk-thomas added the bug Something isn't working label Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants