-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the correct QoS profile to subscribe to an existing topic #569
Comments
Good catch and thanks for submitting an issue. Let me get a handle on the documentation situation and we'll see what we can get done. As a short term band-aid I can point you to this ROSCon talk and slides that should help elucidate things a bit. Perhaps @emersonknapp might be willing to write this considering he already has a body of work around it. |
A really excellent feature for the cli would be auto-qos (we're working on it for rosbag2 because this issue is equally confusing for users there) - I doubt at this point that we'd be able to get that in for Foxy though. Something I could do in the short term to at least educate users would be to update https://index.ros.org/doc/ros2/Concepts/About-Quality-of-Service-Settings/ - @kscottz do you think that'd be the best place to update this information? I was thinking -
|
@emersonknapp thanks for the update. That seems like a reasonable approach but I defer to @maryaB-osr opinion. If we're not going to have this directly fixed by foxy it might be worth noting the issue experienced above so google searches might direct people to the right place and the TL;DR on how to fix it. |
It's not a fix as much as an upgrade that would clear up confusion. If the user does the following they'll successfully see the messages:
This will be the most common case for the beginning ROS 2 user, is that the |
@kscottz @emersonknapp All sounds good to me, please feel free to proceed. Thanks! |
This issue has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/using-text-programming-robots-with-ros-advice/13262/9 |
What should be the quality of service to listen to |
If your subscription requests
It will be universally compatible with any publisher, even if you don't know what the publisher is offering - so that's always a safe choice. Using that does mean that you won't receive |
Oh and as a heads up on the Wiki page, it's still on my plate to have it fully up to date in time for the Foxy release, so that means I'll be opening up the PR within the next week or two. |
This issue has been mentioned on ROS Discourse. There might be relevant details there: |
We stumbled upon this issue when implementing for Turtlebot3 a node that subscribes to its lidar.
We would just get nothing when subscribing using the default parameters: no data, no error. Nothing.
ros2 topic echo /scan
was displaying LaserScans alright.The choosing of the correct QoS setting is not documented anywhere obvious (if not anywhere ?). It does not appear in any of the tutorials, and moreover I found online no copy/paste code example setting one other than the default, like
sensor_data
. We found out about QoS settings and their inter-compatibility by following Github issue trackers.I believe this could be documented better so I'm opening this issue for reference.
The text was updated successfully, but these errors were encountered: