add thread naming utilities #213
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Aposhian <adam.aposhian@fireflyautomatix.com>
ahcorde
requested changes
Jun 17, 2025
src/thread_name.cpp
Outdated
|
|
||
| // This includes the null terminator | ||
| #if defined(__APPLE__) | ||
| constexpr size_t MAXTHREADNAMESIZE = 64; |
src/thread_name.cpp
Outdated
| std::error_code error_code(result, std::system_category()); | ||
| throw std::system_error(error_code, "Failed to get thread name"); | ||
| } | ||
| std::wstringstream wss; |
There was a problem hiding this comment.
It is included, but only on windows.
|
|
||
| std::string get_thread_name() | ||
| { | ||
| std::string name; |
Signed-off-by: Adam Aposhian <adam.aposhian@fireflyautomatix.com>
Signed-off-by: Adam Aposhian <adam.aposhian@fireflyautomatix.com>
Signed-off-by: Adam Aposhian <adam.aposhian@fireflyautomatix.com>
Aposhian
force-pushed
the
2818-custom-thread-names
branch
from
230621f to
2a2a955
Compare
Signed-off-by: Adam Aposhian <adam.aposhian@fireflyautomatix.com>
|
I finally got my Windows development environment up, so I was able to test, and now this compiles and tests pass on Windows. I have still not tested on Apple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved thread naming utilities from ros2/rclcpp#2871.
Fixes ros2/rclcpp#2818
Is this user-facing behavior change?
No, just new interfaces.
Did you use Generative AI?
Yes. Cursor autocomplete.
Additional Information