Fix a comparison with a sign mismatch (#771)

cottsay · web-flow · commit 5a5a1fe53005 · 2019-06-26T10:26:07.000-07:00
Signed-off-by: Scott K Logan &lt;logans@cottsay.net&gt;
diff --git a/rclcpp/src/rclcpp/node_options.cpp b/rclcpp/src/rclcpp/node_options.cpp
@@ -98,7 +98,7 @@ NodeOptions::get_rcl_node_options() const
       }
     }
 
-    if (this->arguments_.size() > std::numeric_limits<int>::max()) {
+    if (this->arguments_.size() > static_cast<size_t>(std::numeric_limits<int>::max())) {
       throw_from_rcl_error(RCL_RET_INVALID_ARGUMENT, "Too many args");
     }
 

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ NodeOptions::get_rcl_node_options() const`
`98`	`98`	`}`
`99`	`99`	`}`
`100`	`100`
`101`		`- if (this->arguments_.size() > std::numeric_limits<int>::max()) {`
	`101`	`+ if (this->arguments_.size() > static_cast<size_t>(std::numeric_limits<int>::max())) {`
`102`	`102`	`throw_from_rcl_error(RCL_RET_INVALID_ARGUMENT, "Too many args");`
`103`	`103`	`}`
`104`	`104`