Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve names of executables and mention them in the readme #160

Open
dirk-thomas opened this issue Dec 19, 2016 · 7 comments
Open

improve names of executables and mention them in the readme #160

dirk-thomas opened this issue Dec 19, 2016 · 7 comments

Comments

@dirk-thomas
Copy link
Member

Currently the names are only discoverable by using the shell completion if you know that they start with examples_rclcpp_minimal_. They are not mentioned anywhere in the README files.

Also why having the suffix _main for examples_rclcpp_minimal_client_main?

@codebot
Copy link
Member

codebot commented Dec 19, 2016

Yeah I wasn't sure how else to make sure they didn't collide with other binaries when they are installed to the global bin directory, so I put that long ugly prefix on them.

The idea for the _main suffix for examples_rclcpp_minimal_client_main is because it has a main() function, and at some point (e.g., Beta 2) I'm hoping to add more examples that do not have a main() but instead use the forthcoming handy macros and generic launcher to allow easy component-style coding.

@mikaelarguedas
Copy link
Member

These executables are now installed to libexec and renamed. The readme's dont refer to it yet so this is only documentation

@davetcoleman
Copy link

davetcoleman commented Jan 24, 2019

I would also appreciate an explanation of the term "not_composable" in the actionlib example, perhaps inside the file or in the README.

The actions README should link back to its tutorial, if one exists. Perhaps that is where "composable" is defined?

I'll PR it myself if someone could explain it to me.

@jacobperron
Copy link
Member

@davetcoleman My understanding is "composable" refers to the ability for a node to be used as part of a Composition (running multiple nodes in a single process). The Action examples followed the naming convention from the minimal publisher and minimal subscriber examples. But, the executables that are not labeled as "not composable" are not composable either (not shared libraries)... Since there already exists a composition demo, I think that a different naming convention should be instated here.

The actions README should link back to its tutorial, if one exists. Perhaps that is where "composable" is defined?

Currently, a tutorial does not exist, but I think it's a good idea to link to a tutorial once it does.

@davetcoleman
Copy link

Thanks for the explanation.

Since there already exists a composition demo, I think that a different naming convention should be instated here.

You mean rename the source files, right? I don't understand all of this enough to provide input on that.

@jacobperron
Copy link
Member

You mean rename the source files, right?

Yeah, the source files and executables.

It looks like the README's for minimal_publisher and minimal_subscriber have explanations of "composable", so at the very least a similar description can be added to the action and service examples.

Perhaps I'm mistaken about the meaning of "composable" here, if all it means is subclassing from Node, then the naming scheme here might be fine. If so, we should make sure to add "composable" examples for services and actions.

@davetcoleman
Copy link

I've submitted documentation as promised: #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants