Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code line does not match the official tutorial #702

Closed
peterwarlg opened this issue Aug 29, 2024 · 1 comment · Fixed by #701
Closed

code line does not match the official tutorial #702

peterwarlg opened this issue Aug 29, 2024 · 1 comment · Fixed by #701
Assignees

Comments

@peterwarlg
Copy link

with the Fibonacci.action file defined in official action tutorial as:

# Request
---
# Result
---
# Feedback

Code here should be modified to auto & sequence = feedback->partial_sequence;, otherwise it cannot be compiled successfully

https://github.com/ros2/examples/blob/8a9fbfb54ffb600728644f2f310a8f4b1e23d5b6/rclcpp/actions/minimal_action_server/member_functions.cpp#L76

@clalancette
Copy link
Contributor

Sigh. This whole thing is confusing because we have Fibonacci.action defined three times:

That said, if you follow the tutorial from https://docs.ros.org/en/humble/Tutorials/Intermediate/Creating-an-Action.html#defining-an-action to https://docs.ros.org/en/humble/Tutorials/Intermediate/Writing-an-Action-Server-Client/Cpp.html, it should do the right thing.

The action here is really to remove two of those three definitions of Fibonacci we have in the code; there is really no reason for three copies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants