Remove libc dependencies #284
Conversation
|
@Tacha-S this is looking great, thanks! Let us know when it's ready for review |
|
I was developing with 1.64. https://doc.rust-lang.org/src/std/ffi/mod.rs.html#157 Which version should be support? |
|
I don't fully understand – the compiler error sounds like 1.63 has Either way, I think it would be nice to support 1.63 if it's not too ugly. Maybe that requires using |
|
|
| out_seq.resize_to_at_least(in_seq.len()); | ||
| out_seq.clone_from_slice(in_seq.as_slice()); | ||
| true | ||
| // SAFETY: This is safe since a the point is guaranteed to be valid/initialized. |
There was a problem hiding this comment.
| // SAFETY: This is safe since a the point is guaranteed to be valid/initialized. | |
| // SAFETY: This is safe since the pointer is guaranteed to be valid/initialized. |
rosidl_runtime_rs/src/traits.rs
Outdated
| @@ -42,7 +42,7 @@ pub trait RmwMessage: Clone + Debug + Default + Send + Sync + Message { | |||
| const TYPE_NAME: &'static str; | |||
|
|
|||
| /// Get a pointer to the correct `rosidl_message_type_support_t` structure. | |||
| fn get_type_support() -> libc::uintptr_t; | |||
| fn get_type_support() -> usize; | |||
There was a problem hiding this comment.
While we're here – could we make this pointer and the one in the Service trait a *const c_void?
std::ffi